angular-cn

Commit Graph

Author	SHA1	Message	Date
Keen Yee Liau	31bec8ce61	feat(compiler): Propagate source span and value span to Variable AST (#36047 ) This commit propagates the `sourceSpan` and `valueSpan` of a `VariableBinding` in a microsyntax expression to `ParsedVariable`, and subsequently to View Engine Variable AST and Ivy Variable AST. Note that this commit does not propagate the `keySpan`, because it involves significant changes to the template AST. PR Close #36047	2020-03-16 10:52:57 -07:00
Keen Yee Liau	24f32e373d	test(compiler): add correct use case of ngFor in r3 ast (#35671 ) The only test case for `ngFor` exercises an incorrect usage which causes two bound attributes to be generated . This commit adds a canonical and correct usage to show the difference between the two. PR Close #35671	2020-02-25 13:09:08 -08:00
JoostK	489cef6ea2	feat(ivy): include value spans for attributes, variables and references (#30181 ) Template AST nodes for (bound) attributes, variables and references will now retain a reference to the source span of their value, which allows for more accurate type check diagnostics. PR Close #30181	2019-07-25 16:36:32 -07:00

Author

SHA1

Message

Date

Keen Yee Liau

31bec8ce61

feat(compiler): Propagate source span and value span to Variable AST (#36047 )

This commit propagates the `sourceSpan` and `valueSpan` of a `VariableBinding`
in a microsyntax expression to `ParsedVariable`, and subsequently to
View Engine Variable AST and Ivy Variable AST.

Note that this commit does not propagate the `keySpan`, because it involves
significant changes to the template AST.

PR Close #36047

2020-03-16 10:52:57 -07:00

Keen Yee Liau

24f32e373d

test(compiler): add correct use case of ngFor in r3 ast (#35671 )

The only test case for `ngFor` exercises an incorrect usage which causes
two bound attributes to be generated . This commit adds a canonical and
correct usage to show the difference between the two.

PR Close #35671

2020-02-25 13:09:08 -08:00

JoostK

489cef6ea2

feat(ivy): include value spans for attributes, variables and references (#30181 )

Template AST nodes for (bound) attributes, variables and references will
now retain a reference to the source span of their value, which allows
for more accurate type check diagnostics.

PR Close #30181

2019-07-25 16:36:32 -07:00

3 Commits