honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
17,773 Commits 5 Branches 1 Tag 210 MiB
Commit Graph

70 Commits

Author SHA1 Message Date
Martin Sikora d9c4840a9c fix(router): cancel navigation when at least one resolver completes with no "next" emission (#24621) 
This change aligns behavior for resolvers which return EMPTY. Currently EMPTY resolvers have inconsistent behavior:
- One resolver that returns EMPTY => won't navigate and just ends on ResolveStart router event.
- Two resolvers where both return EMPTY => throws "Error: Uncaught (in promise): EmptyError: no elements in sequence"
- Two resolvers where one returns a value and the other one returns EMPTY => Navigates successfully.
With this change any EMPTY resolver will cancel navigation.

BREAKING CHANGE: Any resolver which return EMPTY will cancel navigation.
If you want to allow the navigation to continue, you will need to update the resolvers to emit
some value, (i.e. defaultIfEmpty(...), of(...), etc).
PR Close #24195

PR Close #24621
 2020-05-04 12:36:49 -07:00
Grant Fleming cae2a893f2 docs: fix typo (#36786) 
Correct typo in the router docs, changing "as your app growns" to "as your app grows". Previously the wrong spelling was used and this commit rectifies this.

PR Close #36786
 2020-04-27 12:50:42 -07:00
Judy Bogart 75dff8a93a docs: improve startup nav, naming, and terminology (#35533) 
PR Close #35533
 2020-04-22 17:08:29 -04:00
Kapunahele Wong 305b059809 docs: refactor routing doc (#35566) 
This rewrite changes headings to focus on user tasks rather than features,
verifies that content is up-to-date and complete, removes colloquial phrases,
adds prerequisites, and expands on a task-based section in the beginning
(a quick reference).

PR Close #35566
 2020-04-16 10:36:01 -07:00
Judy Bogart e1ac2efe4a docs: make page titles and toc task-oriented (#36024) 
PR Close #36024
 2020-04-01 13:16:48 -07:00
Sonu Kapoor a7d5c55926 docs: fix routing code to use `navigate` (#35176) 
Previously, the example in the `router` guide was not
preserving the query params after logging in.

This commit fixes this by using `navigate` instead of
using `navigateByUrl`, which ignores any properties in
the `NavigationExtras` that would change the provided URL.

Fixes 34917

PR Close #35176
 2020-02-24 09:00:03 -08:00
Aravind 1be5b69174 docs: fix typo on router guide (#34911) 
closes #34907
PR Close #34911
 2020-01-22 14:32:56 -08:00
Judy Bogart efdf347f9c docs: apply standard header case convention (#34196) 
PR Close #34196
 2020-01-10 08:38:53 -08:00
Kapunahele Wong d655093123 docs: add Animations import in Router doc (#33740) 
Fixes #33665

PR Close #33740
 2019-11-25 22:37:55 -05:00
Stefanie Fluin fe4447d568 feat(docs-infra): simplify image styles and remove figure references (#33748) 
Reference #33259
Removes figures elements as AIO is not typically using captions or image groups where figures would be necessary or appropriate

PR Close #33748
 2019-11-14 09:27:02 -08:00
thanhpd 2f6c97e93c docs: remove redundant whitespaces and fix minor typos (#33422) 
PR Close #33422
 2019-10-29 11:39:17 -07:00
Stefanie Fluin ba29e4d953 feat(docs-infra): implement figure styles (#33259) 
PR#28396 originally addressed an update via issue #23983 to make images more visible with a white background (implementation of gray "lightbox").

This PR implements those styles defined in PR#28396.

PR Close #33259
 2019-10-23 12:59:34 -07:00
Judy Bogart e3f42818e9 docs: add detail to router event doc (#32140) 
PR Close #32140
 2019-08-27 16:17:06 -07:00
George Kalpakas 1bcd58cee8 refactor(docs-infra): remove `linenums=false` since it is now the default (#31674) 
PR Close #31674
 2019-07-24 14:38:54 -07:00
Brandon e1af6e3c70 docs: use dynamic import syntax in examples using lazy loading (#30563) 
PR Close #30563
 2019-05-21 09:09:35 -07:00
Richard Lea d6538eb2fd docs: fix naming miss and improve anchor reference in router guide (#30225) 
Signed-off-by: Richard Lea <chigix@zoho.com>

PR Close #30225
 2019-05-06 11:48:05 -07:00
Vani ddb935fac7 docs: update examples region to match the description in the guide (#29259) 
PR Close #29259
 2019-04-02 16:09:19 -07:00
Kapunahele Wong e8921365b7 docs: remove coremodule references (#28434) 
PR Close #28434
 2019-03-29 10:29:51 -07:00
Brandon Roberts 8ed13a37f0 docs: clarify commands to integrate routing (#26530) 
PR Close #26530
 2019-03-14 18:26:53 -04:00
Brandon 2064508876 docs: fix redirect with secondary outlet in router guide example (#29267) 
The URL wasn't be parsed into a UrlTree, so redirecting with a
secondary route went to a 404

Closes #28805

PR Close #29267
 2019-03-14 10:51:52 -04:00
SebastienBtr cb0a8b566f docs(router): change slideInDownAnimation into slideInAnimation (#28640) 
In the Routing & Navigation there is a typo - slideInDownAnimation, but it should be slideInAnimation

PR Close #28572

PR Close #28640
 2019-02-13 12:03:45 -08:00
Brandon 1941d7c743 docs: ignore initial components for app compilation in router example (#28592) 
PR Close #28592
 2019-02-11 17:09:25 +00:00
Luiz Machado 1fb6731285 docs: fix crisis-detail milestone files (#27025) 
Crisis Detail's template was being added two times and the component's TS none.
PR Close #27025
 2019-01-22 11:19:51 -08:00
Hamza TEI 1df8be5573 docs: update link to post on redirects in router guide (#27256) 
Change victor savkin's url post on redirects to:
http://vsavkin.tumblr.com/post/146722301646/angular-router-empty-paths-componentless-routes

PR Close #27256
 2019-01-22 11:17:18 -08:00
Joseph Harrison-Lim bccf8da35f docs(router): fix misnamed path (#27879) 
This change matches the routes found in the following code example
for auth.guard.ts as well as the login.component.1.ts in the "Add
the LoginComponent" section.

PR Close #27879
 2019-01-10 17:06:05 -08:00
Michael De Wree 582395b8f5 docs: fix typo PageNotFoundCompponent (#27799) 
closes: #27795

PR Close #27799
 2019-01-09 12:42:39 -08:00
Jason Aden 4e9f2e5895 feat(router): guard returning UrlTree cancels current navigation and redirects (#26521) 
Fixes #24618
FW-153 #resolve

PR Close #26521
 2018-10-31 19:51:50 -04:00
jenniferfell 0ef1f7ef0d docs: change links to cli wiki to link to new aio docs files m to z (#26492) 
PR Close #26492
 2018-10-17 11:06:07 -07:00
William Marques fc6dad40ac fix(docs-infra): rename "title" by "header" to avoid unwanted tooltips (#26396) 
Closes #26174

PR Close #26396
 2018-10-17 11:05:29 -07:00
Atuuh 3683c6a188 docs: fix wording (#26207) 
fix wording to sound better
PR Close #26207
 2018-10-05 14:19:08 -07:00
Brandon Roberts bc88f318f6 docs: update routing integration section based on feedback (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts a5b7008c8e docs: add section on router integration (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts ac5aa8f46d docs: router guide review feedback changes (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts 1fb3c4ffee docs: Update router guide to use Angular CLI (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts 3c8aa0b301 docs: Refresh content on routable animations for router guide (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Stefanie Fluin d523630ea2 docs(aio): cleanup aalert, callout, subsection use and author style (#24986) 
PR Close #24986
 2018-07-24 08:22:14 -07:00
Patrick McDonald 6d8c847e7b docs: fix typo (#23998) 
"Made" doesn't make sense (redoing and closing #23940)
PR Close #23998
 2018-05-22 13:35:13 -04:00
Judy Bogart 9f7bd8f618 docs: update text around changed obs examples (#22920) 
PR Close #22920
 2018-03-29 09:20:04 -07:00
Jesus Rodriguez 1a75934cc0 build(aio): migrate plunker to stackblitz (#20165) 
PR Close #20165
 2018-01-23 21:30:27 -08:00
Kapunahele Wong 53f91189a1 docs(aio): add NgModule docs (#20306) 
PR Close #20306
 2018-01-10 16:26:46 -08:00
Leo Globerman 1adbcda12e docs(aio): fix wrong copy (#20431) 
PR Close #20431
 2017-11-14 15:58:25 -08:00
Brandon Roberts 53be85a7fb docs(aio): Updated usage of Observables in router guide. Added section for advanced redirects (#18197) 
PR Close #18197
 2017-09-05 15:32:49 -05:00
Antoine Mary 416ed691e5 docs(aio): fix URLSearchParams interface link to MDN 
Fixes #18367
 2017-07-28 15:26:04 -07:00
Nicola Sanitate 9208f0beea docs(aio): fix typo in Router documentation 
Fix title and link to RouteConfigLoadEnd documentation
 2017-07-19 15:01:50 +01:00
Kapunahele Wong e110a80caf docs(aio): change Angular Module to NgModule (#16964) 2017-07-11 15:05:20 -07:00
Brandon Roberts 8d01db4638 docs: Updated router guide content and examples for paramMap 
and queryParamMap, tracing, and incidental improvements.
closes #16991 and #16259 which it also fixes.
 2017-06-29 09:35:39 -07:00
Mark Amery 8c129d73b8 docs: Fix some non-code being formatted as code in the router docs 2017-06-22 14:38:55 -07:00
Jesús Rodríguez cd5bc64658 docs(aio): update headers for toc (#16969) 2017-05-26 13:28:06 -06:00
Jesus Rodriguez b016984c04 docs(aio): resize images 2017-05-12 14:28:09 +01:00
Jesus Rodriguez 56833a6171 docs(aio): more content fixes 2017-05-10 12:51:01 +01:00