f378454c92
fix(docs-infra): correctly check PR files on preview server ( #25671 )
...
According to the docs, the response of GitHub's [PR files API][1]
_"includes a maximum of 300 files"_. This means that if a PR contains
more files, it is possible that not all files are retrieved (which
could, for example, give a false negative for the "significant files
touched" check - not likely but possible).
This commit fixes it by using paginated requests to retrieve all changed
files.
[1]: https://developer.github.com/v3/pulls/#list-pull-requests-files
PR Close #25671
2018-09-26 15:26:19 -07:00
c8c8436e58
test(docs-infra): fix test for preview server's `GithubPullRequests` ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
b31c8b6063
test(docs-infra): fix test for preview server's `BuildCleaner` completing prematurely ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
897261efdc
test(docs-infra): fix preview server unit tests on Windows ( #25671 )
...
Some tests where comparing actual with expected paths, without taking
into account that paths will be different on Windows.
This commit uses `path.resolve()` to convert expected paths to their
OS-specific form.
PR Close #25671
2018-09-26 15:26:19 -07:00
35d70ff265
test(docs-infra): add support for source-maps in preview server tests ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
fc0a7959a4
refactor(docs-infra): use mockable logger ( #25671 )
...
Related discussion:
https://github.com/angular/angular/pull/23576#discussion_r187925949 .
PR Close #25671
2018-09-26 15:26:19 -07:00
182c08bee1
refactor(docs-infra): fix method name (getPrfromBranch --> getPrFromBranch) ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
e2bc0ad6c2
build(docs-infra): upgrade preview server dependencies ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
73333ee3e5
build(docs-infra): replace `concurrently` with `npm-run-all` for preview server dev ( #25671 )
...
`npm-run-all` works just as well, but is better at handling termination on Windows.
PR Close #25671
2018-09-26 15:26:19 -07:00
c819859598
build(docs-infra): do not exit preview server `dev` script when `build` fails ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
79aefa7659
build(docs-infra): avoid race condition in `aio-builds-setup/` npm scripts ( #25671 )
...
Previously, due to multiple scripts re-building during `yarn dev`
initialization, there could be race conditions that led to errors.
This commit fixes it by ensuring `yarn build` is run once (before
the main `yarn dev` script).
PR Close #25671
2018-09-26 15:26:19 -07:00
e1990a5a80
docs: firefox web components info ( #26118 )
...
PR Close #26118
2018-09-26 15:25:44 -07:00
f29b218060
feat(docs-infra): generate Angular CLI command reference ( #25363 )
...
PR Close #25363
2018-09-26 11:24:02 -07:00
39a67548ac
build(docs-infra): add option to run only the doc-gen ( #25363 )
...
This can save time when iterating by not
regenerating the zips and embedded examples.
PR Close #25363
2018-09-26 11:24:02 -07:00
bc88f318f6
docs: update routing integration section based on feedback ( #20023 )
...
PR Close #20023
2018-09-26 10:14:49 -07:00
a5b7008c8e
docs: add section on router integration ( #20023 )
...
PR Close #20023
2018-09-26 10:14:49 -07:00
0aafbac99b
docs: clean up providedIn: 'root' syntax for router examples ( #20023 )
...
PR Close #20023
2018-09-26 10:14:49 -07:00
ac5aa8f46d
docs: router guide review feedback changes ( #20023 )
...
PR Close #20023
2018-09-26 10:14:49 -07:00
1fb3c4ffee
docs: Update router guide to use Angular CLI ( #20023 )
...
PR Close #20023
2018-09-26 10:14:49 -07:00
3c8aa0b301
docs: Refresh content on routable animations for router guide ( #20023 )
...
PR Close #20023
2018-09-26 10:14:49 -07:00
d19108531c
docs: cleanup minor changes for forms overview ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
354d1944bb
docs: remove unused properties from forms overview example ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
eaccd03ed7
docs: fix typos from review feedback ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
343df337f4
docs: update with forms overview review feedback ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
9b14483824
docs: more overview feedback changes ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
bd42caf1c7
docs: update nav descriptions based on feedback ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
7db8111973
docs: add updated reactive forms data flow image ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
74fef157e6
docs: updates from review feedback ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
9661bed3ba
docs: add updated forms overview images ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
95168e4de0
docs: integrate forms diagrams into overview ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
13c3e241c8
docs: add final thoughts to forms overview ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
8d098d389a
docs: incorporated forms overview review feedback ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
79a2567aa3
docs: forms overview review changes ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
5649acd03f
docs: add forms overview example for snippets ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
ebd01e8e79
docs: more form overview edits ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
e08955b557
docs: incorporated forms overview feedback ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
04dfca41f4
docs(forms): add package overview for forms ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
129f69c3bc
docs: add forms overview guide ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
c7e2930f25
docs: fix issues related to tutorial. ( #24445 )
...
PR Close #24445
2018-09-25 18:45:19 -07:00
cf095d982d
docs: fix a typo ( #26074 )
...
PR Close #26074
2018-09-24 13:48:24 -07:00
bc02e19831
docs: correct path reference in upgrade guide ( #26072 )
...
The incorrect path is referenced, this is confusing to users following the "Upgrading from AngularJS" guide.
PR Close #26072
2018-09-24 09:13:24 -07:00
47eb2122c0
docs: fix Sajee info in contributors ( #26063 )
...
PR Close #26063
2018-09-24 09:12:45 -07:00
b8422b41bb
build(docs-infra): fail doc-gen if a content rule fails ( #26039 )
...
PR Close #26039
2018-09-24 09:11:02 -07:00
8ac4dd6447
build(docs-infra): allow usage notes on decorator option properties ( #26039 )
...
PR Close #26039
2018-09-24 09:11:02 -07:00
3808416479
build(docs-infra): remove legacy jsdoc tag processing ( #26039 )
...
PR Close #26039
2018-09-24 09:11:02 -07:00
cee7448efc
build(docs-infra): add @nocollapse tag-def to prevent warning ( #26039 )
...
See https://github.com/angular/angular/blob/master/packages/compiler-cli/src/transformers/nocollapse_hack.ts
PR Close #26039
2018-09-24 09:11:02 -07:00
7f1cace2a2
build(docs-infra): sort NgModule exports by id ( #26051 )
...
PR Close #26051
2018-09-21 17:00:03 -07:00
56c86c7e79
build(docs-infra): sort package exports by id ( #26051 )
...
Closes #26046
PR Close #26051
2018-09-21 17:00:03 -07:00
a880686081
fix(docs-infra): ensure that only search is removed from URL on click ( #26056 )
...
When we have navigated to the site via a URL that contains a search
query param, the site shows the search results.
We want to remove that query param from the URL when the search
results are closed, but the current implementation is also removing
other query params unnecessarily.
Now only the search param is removed when the search results are
closed.
See https://github.com/angular/angular/pull/25479/files#r219497804
for more context.
PR Close #26056
2018-09-21 10:29:24 -07:00
026b60cd70
build(docs-infra): expose deprecated status on items more clearly ( #25750 )
...
PR Close #25750
2018-09-21 10:26:48 -07:00
George Kalpakas
arjunyel
Pete Bacon Darwin
Brandon Roberts
Vani
Max Belsky
George Wilde
sajeetharan