Miško Hevery
f8658cdc38
Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )"
...
This reverts commit d47b2a6f70
.
2017-11-15 17:04:22 -06:00
Jason Aden
043e408805
style(core): fix comment format for linter
2017-11-15 11:53:11 -08:00
George Kalpakas
c004d483ab
style(core): fix max line length to pass linting ( #20441 )
...
Accidentally introduced in #19920 , where other linting errors (unrelated to the
PR) prevented proper linting.
PR Close #20441
2017-11-15 11:44:52 -08:00
Jason Aden
2586846ee2
Revert "fix(core): should support event.stopImmediatePropagation"
...
This reverts commit 5e0eb5e3d94bd7077c4d6657b89bfc8d900f2bc6.
2017-11-15 11:35:21 -08:00
Matias Niemelä
d47b2a6f70
fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )
...
Closes #19100
PR Close #19753
2017-11-14 15:59:47 -08:00
Martin Hobert
12af6d356e
docs(core): change from deprecated renderer to renderer2 ( #19920 )
...
We now show the proper class instead of the deprecated Renderer
Fixes #19806
PR Close #19920
2017-11-14 13:44:56 -08:00
Matias Niemelä
20aafff092
fix(animations): ensure final state() styles are applied within @.disabled animations ( #20267 )
...
Closes #20266
PR Close #20267
2017-11-14 11:01:11 -08:00
Mark Kennedy
a622e19df6
fix(router): 'merge' queryParamHandling strategy should be able to remove query params ( #19733 )
...
Closes #18463 , #17202
PR Close #19733
2017-11-14 11:01:04 -08:00
Chuck Jazdzewski
24cf8b3269
fix(core): ensure init lifecycle events are called ( #20258 )
...
Throwing an exception in a lifecycle event will delay but not
prevent an Init method, such as `ngOnInit`, `ngAfterContentInit`,
or `ngAfterViewInit`, from being called. Also, calling `detectChanges()`
in a way that causes duplicate change detection (such as a
child component causing a parent to call `detectChanges()` on its
own `ChangeDetectorRef`, will no longer prevent change `ngOnInit`,
`ngAfterContentInit` and `ngAfterViewInit` from being called.
With this change lifecycle methods are still not guarenteed to be
called but the Init methods will be called if at least one change
detection pass on its view is completed.
Fixes : #17035
PR Close #20258
2017-11-10 13:47:39 -08:00
Bowen Ni
743651f5e8
refactor(animations): uses a loop instead Array.map() which creates and ( #19910 )
...
returns a new array that is discarded.
This pattern will become a compilation error in google3.
PR Close #19910
2017-11-10 13:47:02 -08:00
Chuck Jazdzewski
c33a57666b
fix(compiler): recognize @NgModule with a redundant @Injectable ( #20320 )
...
The compiler now, again, recognizes `@NgModule()` decorators on
classes with a redundant `@Injectable()` decorator.
Fixes : #19544
PR Close #20320
2017-11-10 11:51:52 -08:00
Derek
401ead07b8
docs(common): update default display value for CurrencyPipe ( #20246 )
...
PR Close #20246
2017-11-10 11:51:17 -08:00
Fabian Wiles
b55c2ba342
refactor(core): remove prolyfill from error message ( #20121 )
...
PR Close #20121
2017-11-10 11:51:15 -08:00
Keen Yee Liau
eb8013e853
fix(language-service): pass compilerOptions.paths to ReflectorHost ( #20222 )
...
This commit fixes the options passed to ReflectorHost to include 'paths'
if it's specified in compiler options, so that dependency modules can
be loaded.
PR Close #20222
2017-11-10 11:51:11 -08:00
Harry Pfleger
b4a39f9c30
docs(aio): fix -mm- to -MM- for month in DatePipe ( #20315 )
...
PR Close #20315
2017-11-10 10:58:45 -08:00
Chuck Jazdzewski
3257fcdcee
fix(compiler): show explanatory text in template errors ( #20313 )
...
Fixes : #20076
PR Close #20313
2017-11-09 15:46:30 -08:00
Victor Berchet
9bcd7097d0
test(compiler): do not use `a` as a content selector
...
As it might trigger false positive in the RegExp from `_makeScopeMatcher`
closes #20256
2017-11-08 15:52:21 -08:00
Victor Berchet
c32f5fd393
fix(compiler): fix corner cases in shadow CSS
...
`cmp:host {}` and `cmp:host some-other-selector {}` were not handled
consistently.
Note those should not match anything but are made equivalent to respectively
`:host(cmp)` and `:host(cmp) some-other-selector` to avoid breaking legacy apps.
2017-11-08 15:20:19 -08:00
Victor Berchet
6e8e3bd248
refactor(core): misc changes and integrate review feedback on #19996
...
closes #20224
2017-11-06 14:13:02 -08:00
Tobias Bosch
a460066972
feat(compiler): introduce `TestBed.overrideTemplateUsingTestingModule`
...
This allows to overwrite templates for JIT and AOT components alike.
In contrast to `TestBed.overrideTemplate`, the template is compiled
in the context of the testing module, allowing to use other testing
directives.
Closes #19815
2017-11-06 14:12:30 -08:00
Tobias Bosch
05d96dc507
feat(core): allow to pass in aot summaries also to `TestBed.configureTestingModule`
...
Also adds caching for summaries.
Closes #19817 .
2017-11-06 14:12:30 -08:00
Maxime Robert
b489259a34
docs(common): fix mis-ordered lines ( #20221 )
2017-11-06 11:28:39 -08:00
Chuck Jazdzewski
bf22f2df88
fix(compiler): report a reasonable error with invalid metadata ( #20062 )
...
The compiler would throw an internal exception if an import using
the `ngModule` syntax and the module as not a resolvable symbol.
Fixes : #20049
2017-11-06 10:01:27 -08:00
Igor Minar
3997d97806
revert: feat(elements): implement `@angular/elements` #19469 ( #20152 )
...
This PR was merged without API docs and general rollout plan.
We can't release this as is in 5.1 without a plan for documentation, cli integration, etc.
2017-11-03 15:54:54 -07:00
JiaLiPassion
200d92d030
fix(core): should support event.stopImmediatePropagation ( #19222 )
2017-11-03 15:22:05 -07:00
Victor Berchet
f0764016f9
revert: feat(core): add source to `StaticInjectorError` message ( #19482 ) ( #20171 )
...
This reverts commit faa621218e
.
2017-11-03 14:51:06 -07:00
Olivier Combe
faa621218e
feat(core): add source to `StaticInjectorError` message ( #19482 )
2017-11-03 11:14:05 -07:00
Alex Rickabaugh
1d19d61970
fix(platform-browser): support Symbols in custom jasmineToString() method ( #19794 )
...
It's illegal to coerce a Symbol to a string, and results in a TypeError:
TypeError: Cannot convert a Symbol value to a string
Previously, the custom jasmineToString() method monkey-patched onto Maps
in platform-browser/testing/src/matchers.ts would coerce keys and values
to strings. A change in a newer version of Jasmine calls this method more
often, resulting in calls against Maps which contain Symbols in some
applications, which causes crashes.
The fix is to explicitly convert keys and values to strings, which does
work on Symbols.
2017-11-03 11:11:47 -07:00
Olivier Combe
26f82995f6
fix(compiler): don't overwrite missingTranslation's value in JIT ( #19952 )
2017-11-03 11:08:39 -07:00
George Kalpakas
dcf8840831
feat(elements): implement `registerAsCustomElements()`
...
closes #19469
2017-11-02 16:09:30 -07:00
George Kalpakas
60c0b178af
feat(elements): implement `NgElements`
2017-11-02 16:09:09 -07:00
George Kalpakas
0899f4f8fc
feat(elements): implement `NgElementConstructor`
2017-11-02 16:09:09 -07:00
George Kalpakas
aed4a11d01
feat(elements): implement `NgElement`
2017-11-02 16:09:09 -07:00
George Kalpakas
75cf70ae04
feat(elements): implement `NgElementApplicationContext`
2017-11-02 16:09:09 -07:00
George Kalpakas
6b30fbf94e
feat(elements): implement `extractProjectableNodes()`
2017-11-02 16:09:09 -07:00
George Kalpakas
24f17f913a
feat(elements): implement `utils`
2017-11-02 16:09:09 -07:00
George Kalpakas
ebfa204af0
feat(elements): set up the `elements` package
2017-11-02 16:09:09 -07:00
JiaLiPassion
a28d616e10
fix(core): __symbol__ should return __zone_symbol__ without zone.js loaded ( #19541 )
2017-11-02 16:06:06 -07:00
Alex Eagle
5b16ce9302
fix(compiler-cli): don't report emit diagnostics when --noEmitOnError is off ( #20063 )
2017-11-02 14:49:38 -07:00
Dhyey Thakore
d156e72ad7
docs: Add 0 in padding of 'dd' ( #20107 )
2017-11-02 14:36:22 -07:00
George Kalpakas
901436e46f
docs: fix link texts
...
Fixes #19701
PR Close #19709
2017-11-01 15:44:59 -04:00
Rado Kirov
005a78bd83
refactor: allow compilation with TypeScript 2.5 ( #19966 )
...
A small number of types need to be adjusted. The changes seem to be
backwards compatible with TS 2.4.
PR Close #19966
2017-10-31 00:26:43 -04:00
Hans Larsen
13f8648a00
fix: add missing globals from each rollup configuration ( #20028 )
...
PR Close #20028
2017-10-30 23:09:17 -04:00
Hans Larsen
b6abcb2500
refactor: make all rollup config ES5 compatible ( #20028 )
...
So they can be required by other Node scripts.
PR Close #20028
2017-10-30 23:09:17 -04:00
Tobias Bosch
54480f7dfc
fix(compiler): report errors properly in G3 in certain conditions ( #20041 )
...
Condition: static analysis error, given:
- noResolve:true
- generateCodeForLibraries: false
- CompilerHost.getSourceFile throws on non existent files
All of these are true in G3.
PR Close #20041
2017-10-30 21:24:30 -04:00
Tobias Bosch
420852e2f5
fix(compiler): reexport less symbols in `.ngfactory.ts` files ( #19884 )
...
* don't reexport symbols that the user already reexported
* never reexport symbols that are part of arguments of non simple function calls
Fixes #19883
PR Close #19884
2017-10-30 20:11:29 -04:00
Tobias Bosch
04eb80cc2b
fix(compiler): always use relative paths to refer to generated code
...
Previously we generated imports like `@angular/material/index.ngfactory`,
which doesn’t make sense as we don’t ship generated code on npm
Closes #20031
2017-10-30 18:28:25 -04:00
Chuck Jazdzewski
22c66f0e02
fix(compiler-cli): avoid producing source mappings for host views ( #19965 )
...
The host view doesn't map back to user code so the template compiler
produces a blank `url` for them.
PR Close #19965
2017-10-27 22:26:57 -07:00
Hans Larsen
00bc80bb37
fix(platform-server): add missing packages to the UMD global rollup config
...
This adds the proper bindings for calling angular packages from platform-server in the UMD.
This was not a problem for universal apps that dont use UMD.
Fixes 19899
2017-10-27 22:26:25 -07:00
Tobias Bosch
31797d3b50
fix(compiler): make watch mode work on windows ( #19953 )
...
Fixes #19951
PR Close #19953
2017-10-26 18:43:00 -04:00