angular-cn

Commit Graph

Author	SHA1	Message	Date
Joey Perrott	698b0288be	build: reformat repo to new clang@1.4.0 (#36613 ) PR Close #36613	2020-04-14 12:08:36 -07:00
Jason Aden	e8768acacc	fix(common): escape query selector used when anchor scrolling (#29577 ) When an anchor scroll happens, we run document.querySelector. This value can be taken directly from the user. Therefore it's possible to throw an error on scrolling, which can cause the application to fail. This PR escapes the selector before using it. Related to #28193 [Internal discussion](https://groups.google.com/a/google.com/forum/#!topic/angular-users/d82GHfmRKLc) PR Close #29577	2019-03-29 10:39:38 -07:00

Author

SHA1

Message

Date

Joey Perrott

698b0288be

build: reformat repo to new clang@1.4.0 (#36613 )

PR Close #36613

2020-04-14 12:08:36 -07:00

Jason Aden

e8768acacc

fix(common): escape query selector used when anchor scrolling (#29577 )

When an anchor scroll happens, we run document.querySelector. This value can be taken directly from the user. Therefore it's possible to throw an error on scrolling, which can cause the application to fail.

This PR escapes the selector before using it.

Related to #28193
[Internal discussion](https://groups.google.com/a/google.com/forum/#!topic/angular-users/d82GHfmRKLc)

PR Close #29577

2019-03-29 10:39:38 -07:00

2 Commits