9456eca7c5
Adds better caching for browser archives and their extraction. This is done because the archives are currently extracted as a build action and these are actions are invalidated frequently, causing flakiness on the CI and slow-down in local development. Here is an example flaky error on the CI (that surfaces often with RBE execution): ``` ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/npm/@angular/dev-infra-private/bazel/browsers/chromium/BUILD.bazel:22:17: Extracting ../org_chromium_chromium_amd64/file/chrome-linux.zip failed: (Exit 34): extract.sh failed: error executing command external/io_bazel_rules_webtesting/web/internal/extract.sh external/org_chromium_chromium_amd64/file/chrome-linux.zip ... (remaining 2 argument(s) skipped). Note: Remote connection/protocol failed with: execution failed ``` We fix this by introducing a new rule that downloads a browser archive and unpacks it directly into a Bazel repository. Before this change, the archive would just be downloaded but extracted later as part of a build action. This is unnecessary and results in less efficient caching as build actions are invalidated more often, especially if developers run `bazel clean` in between. The root cause on why the extraction often fails in RBE containers is unclear. It's unclear why the extacted archive is not cached properly as part of a build action (most likely some hermeticity issue within `rules_webtesting`, but it seems more Bazel-idiomatic to unpack the archives as part of the repository anyway, and this solves the flakiness issue. PR Close #42814
55 lines
2.0 KiB
Python
55 lines
2.0 KiB
Python
load("//dev-infra/bazel/browsers:browser_archive_repo.bzl", "browser_archive")
|
|
|
|
"""
|
|
Defines repositories for Firefox that can be used inside Karma unit tests
|
|
and Protractor e2e tests with Bazel.
|
|
"""
|
|
|
|
def define_firefox_repositories():
|
|
# Instructions on updating the Firefox version can be found in the `README.md` file
|
|
# next to this file.
|
|
|
|
browser_archive(
|
|
name = "org_mozilla_firefox_amd64",
|
|
licenses = ["reciprocal"], # MPL 2.0
|
|
sha256 = "601e5a9a12ce680ecd82177c7887dae008d8f33690da43be1a690b76563cd992",
|
|
# Firefox v84.0
|
|
url = "https://ftp.mozilla.org/pub/firefox/releases/84.0/linux-x86_64/en-US/firefox-84.0.tar.bz2",
|
|
named_files = {
|
|
"FIREFOX": "firefox/firefox",
|
|
},
|
|
)
|
|
|
|
browser_archive(
|
|
name = "org_mozilla_firefox_macos",
|
|
licenses = ["reciprocal"], # MPL 2.0
|
|
sha256 = "4c7bca050eb228f4f6f93a9895af0a87473e03c67401d1d2f1ba907faf87fefd",
|
|
# Firefox v84.0
|
|
url = "https://ftp.mozilla.org/pub/firefox/releases/84.0/mac/en-US/Firefox%2084.0.dmg",
|
|
named_files = {
|
|
"FIREFOX": "Firefox.app/Contents/MacOS/firefox",
|
|
},
|
|
)
|
|
|
|
browser_archive(
|
|
name = "org_mozilla_geckodriver_amd64",
|
|
licenses = ["reciprocal"], # MPL 2.0
|
|
sha256 = "61bfc547a623d7305256611a81ecd24e6bf9dac555529ed6baeafcf8160900da",
|
|
# Geckodriver v0.28.0
|
|
url = "https://github.com/mozilla/geckodriver/releases/download/v0.28.0/geckodriver-v0.28.0-linux64.tar.gz",
|
|
named_files = {
|
|
"GECKODRIVER": "geckodriver",
|
|
},
|
|
)
|
|
|
|
browser_archive(
|
|
name = "org_mozilla_geckodriver_macos",
|
|
licenses = ["reciprocal"], # MPL 2.0
|
|
sha256 = "c288ff6db39adfd5eea0e25b4c3e71bfd9fb383eccf521cdd65f67ea78eb1761",
|
|
# Geckodriver v0.28.0
|
|
url = "https://github.com/mozilla/geckodriver/releases/download/v0.28.0/geckodriver-v0.28.0-macos.tar.gz",
|
|
named_files = {
|
|
"GECKODRIVER": "geckodriver",
|
|
},
|
|
)
|