Updates to rules_nodejs 2.2.0. This is the first major release in 7 months and includes a number of features as well as breaking changes. Release notes: https://github.com/bazelbuild/rules_nodejs/releases/tag/2.0.0 Features of note for angular/angular: * stdout/stderr/exit code capture; this could be potentially be useful * TypeScript (ts_project); a simpler tsc rule that ts_library that can be used in the repo where ts_library is too heavy weight Breaking changes of note for angular/angular: * loading custom rules from npm packages: `ts_library` is no longer loaded from `@npm_bazel_typescript//:index.bzl` (which no longer exists) but is now loaded from `@npm//@bazel/typescript:index.bzl` * with the loading changes above, `load("@npm//:install_bazel_dependencies.bzl", "install_bazel_dependencies")` is no longer needed in the WORKSPACE which also means that yarn_install does not need to run unless building/testing a target that depends on @npm. In angular/angular this is a minor improvement as almost everything depends on @npm. * @angular/bazel package is also updated in this PR to support the new load location; Angular + Bazel users that require it for ng_package (ng_module is no longer needed in OSS with Angular 10) will need to load from `@npm//@angular/bazel:index.bzl`. I investigated if it was possible to maintain backward compatability for the old load location `@npm_angular_bazel` but it is not since the package itself needs to be updated to load from `@npm//@bazel/typescript:index.bzl` instead of `@npm_bazel_typescript//:index.bzl` as it depends on ts_library internals for ng_module. * runfiles.resolve will now throw instead of returning undefined to match behavior of node require Other changes in angular/angular: * integration/bazel has been updated to use both ng_module and ts_libary with use_angular_plugin=true. The latter is the recommended way for rules_nodejs users to compile Angular 10 with Ivy. Bazel + Angular ViewEngine is supported with @angular/bazel <= 9.0.5 and Angular <= 8. There is still Angular ViewEngine example on rules_nodejs https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular_view_engine on these older versions but users that want to update to Angular 10 and are on Bazel must switch to Ivy and at that point ts_library with use_angular_plugin=true is more performant that ng_module. Angular example in rules_nodejs is configured this way as well: https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular. As an aside, we also have an example of building Angular 10 with architect() rule directly instead of using ts_library with angular plugin: https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular_bazel_architect. NB: ng_module is still required for angular/angular repository as it still builds ViewEngine & @angular/bazel also provides the ng_package rule. ng_module can be removed in the future if ViewEngine is no longer needed in angular repo. * JSModuleInfo provider added to ng_module. this is for forward compat for future rules_nodejs versions. PR Close #39182
		
			
				
	
	
		
			35 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			35 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
| # BEGIN-DEV-ONLY
 | |
| load("//tools:defaults.bzl", "pkg_npm")
 | |
| 
 | |
| pkg_npm(
 | |
|     name = "npm_package",
 | |
|     srcs = glob(
 | |
|         ["*"],
 | |
|         exclude = ["yarn.lock"],
 | |
|     ) + [
 | |
|         "//packages/bazel/src:package_assets",
 | |
|         "//packages/bazel/src/api-extractor:package_assets",
 | |
|         "//packages/bazel/src/ng_package:package_assets",
 | |
|         "//packages/bazel/src/ngc-wrapped:package_assets",
 | |
|         "//packages/bazel/third_party/github.com/bazelbuild/bazel/src/main/protobuf:package_assets",
 | |
|     ],
 | |
|     nested_packages = [
 | |
|         "//packages/bazel/docs",
 | |
|     ],
 | |
|     substitutions = {
 | |
|         "(#|\/\/)\\s+BEGIN-DEV-ONLY[\\w\W]+?(#|\/\/)\\s+END-DEV-ONLY": "",
 | |
|         "//packages/bazel/": "//@angular/bazel/",
 | |
|         "@npm//@bazel/typescript/internal:": "//@bazel/typescript/internal:",
 | |
|     },
 | |
|     tags = ["release-with-framework"],
 | |
|     # Do not add more to this list.
 | |
|     # Dependencies on the full npm_package cause long re-builds.
 | |
|     visibility = ["//integration:__pkg__"],
 | |
|     deps = [
 | |
|         "//packages/bazel/src/api-extractor:lib",
 | |
|         "//packages/bazel/src/ng_package:lib",
 | |
|         "//packages/bazel/src/ngc-wrapped:ngc_lib",
 | |
|     ],
 | |
| )
 | |
| # END-DEV-ONLY
 |