46caf88b2c
Adds support for `getDefinitionAt` when called on a templateUrl property assignment. The currrent architecture for getting definitions is designed to be called on templates, so we have to introduce a new `getTsDefinitionAndBoundSpan` method to get Angular-specific definitions in TypeScript files and pass a `readTemplate` closure that will read the contents of a template using `TypeScriptServiceHost#getTemplates`. We can probably go in and make this nicer in a future PR, though I'm not sure what the best architecture should be yet. Part of angular/vscode-ng-language-service#111 PR Close #32238
Angular Language Service Test
This directory is an integration test for @angular/language-service to ensure
that the language service works correctly as a tsserver plugin.
To use the tests:
- Use
yarn installto install all dependencies in this directory and in the Angular repo root directory. - From the Angular repo root directory, build Angular in the
dist/packages-distfolder with./scripts/build-packages-dist.sh. - In this directory, run the tests with
yarn test.
Update golden files
If the expected output needs to be updated, run yarn golden my-golden.json, replacing
my-golden.json with the golden file to be updated. Do not qualify the file with a directory path.
See generate.ts for more information.
Adding a new fixture
Currently there is no automated way to produce a new fixture. The way the
current fixtures were created was to hack a version of tsserver.js to write the
commands from VSCode to a file while performing the operation to be tested.
I also hand modified the input to remove superfluous request.
Once a new fixture is created:
- Add the fixture name to
goldens/ - Run
yarn golden my-golden.json, replacingmy-golden.jsonwith the new fixture name, to produce the expected output files. - Hand validate that the expected output is reasonable.