angular-cn/packages/compiler-cli/ngcc/src
Alex Rickabaugh 02bab8cf90 fix(ivy): in ngcc, handle inline exports in commonjs code (#32129)
One of the compiler's tasks is to enumerate the exports of a given ES
module. This can happen for example to resolve `foo.bar` where `foo` is a
namespace import:

```typescript
import * as foo from './foo';

@NgModule({
  directives: [foo.DIRECTIVES],
})
```

In this case, the compiler must enumerate the exports of `foo.ts` in order
to evaluate the expression `foo.DIRECTIVES`.

When this operation occurs under ngcc, it must deal with the different
module formats and types of exports that occur. In commonjs code, a problem
arises when certain exports are downleveled.

```typescript
export const DIRECTIVES = [
  FooDir,
  BarDir,
];
```

can be downleveled to:

```javascript
exports.DIRECTIVES = [
  FooDir,
  BarDir,
```

Previously, ngtsc and ngcc expected that any export would have an associated
`ts.Declaration` node. `export class`, `export function`, etc. all retain
`ts.Declaration`s even when downleveled. But the `export const` construct
above does not. Therefore, ngcc would not detect `DIRECTIVES` as an export
of `foo.ts`, and the evaluation of `foo.DIRECTIVES` would therefore fail.

To solve this problem, the core concept of an exported `Declaration`
according to the `ReflectionHost` API is split into a `ConcreteDeclaration`
which has a `ts.Declaration`, and an `InlineDeclaration` which instead has
a `ts.Expression`. Differentiating between these allows ngcc to return an
`InlineDeclaration` for `DIRECTIVES` and correctly keep track of this
export.

PR Close #32129
2019-08-15 14:45:59 -07:00
..
analysis fix(ivy): in ngcc, handle inline exports in commonjs code (#32129) 2019-08-15 14:45:59 -07:00
dependencies refactor(ivy): ngcc - make `EntryPointJsonProperty`-related types and checks a little more strict (#32052) 2019-08-08 11:14:38 -07:00
entry_point_finder fix(ivy): ngcc - handle pathMappings to files rather then directories (#30525) 2019-07-09 09:40:46 -07:00
execution fix(ivy): ngcc - correctly update `package.json` when `createNewEntryPointFormats` is true (#32052) 2019-08-08 11:14:38 -07:00
host fix(ivy): in ngcc, handle inline exports in commonjs code (#32129) 2019-08-15 14:45:59 -07:00
logging feat(compiler-cli): ngcc - make logging more configurable (#29591) 2019-04-01 11:53:28 -07:00
migrations fix(ivy): in ngcc, handle inline exports in commonjs code (#32129) 2019-08-15 14:45:59 -07:00
packages feat(ivy): show error when trying to publish NGCC'd packages (#32031) 2019-08-08 11:17:38 -07:00
rendering fix(ivy): ngcc emits static fields before extra statements (#31933) 2019-08-01 10:45:36 -07:00
writing fix(ivy): ngcc - correctly update `package.json` when `createNewEntryPointFormats` is true (#32052) 2019-08-08 11:14:38 -07:00
constants.ts refactor(ivy): move ngcc into a higher level folder (#29092) 2019-03-20 14:45:54 -04:00
main.ts fix(ivy): ngcc - correctly update `package.json` when `createNewEntryPointFormats` is true (#32052) 2019-08-08 11:14:38 -07:00
utils.ts fix(ivy): ngcc - recognize suffixed tslib helpers (#31614) 2019-07-29 16:10:58 -07:00