angular-cn/packages/core/schematics/migrations/static-queries
Paul Gschwendtner 164d160b22 refactor(core): static-query migrations fails if options cannot be transformed (#30178)
Currently the `static-query` migrations fails at the final step of
updating a query when the query already specifies options which
cannot be transformed easily. e.g. the options are computed through
a function call: `@ViewChild(..., getQueryOpts());` or `@ViewChild(..., myOptionsVar)`.

In these cases we technically could add additionally logic to update
the query options, but given that this is an edge-case and it's
potentially over-engineering the migration schematic, we just
always add a TODO for the timing and print out the determined
query timing in the console. The developer in that case just needs
to manually update the logic for the query options to contain the
printed query timing.

Potentially related to: https://github.com/angular/angular-cli/issues/14298

PR Close #30178
2019-04-29 13:30:37 -07:00
..
angular refactor(core): add static-query template strategy (#29815) 2019-04-15 10:53:54 -07:00
google3 refactor(core): static-query migrations fails if options cannot be transformed (#30178) 2019-04-29 13:30:37 -07:00
strategies refactor(core): static-query migration should not fail for test files (#30034) 2019-04-23 08:32:35 -07:00
BUILD.bazel refactor(core): allow developers to select static-query migration strategy (#29876) 2019-04-18 18:22:09 -07:00
index.ts refactor(core): static-query migrations fails if options cannot be transformed (#30178) 2019-04-29 13:30:37 -07:00
transform.ts refactor(core): static-query migrations fails if options cannot be transformed (#30178) 2019-04-29 13:30:37 -07:00