f40d51733a
Prior to this change we manage a local version of commit message validation
in addition to the commit message validation tool contained in the ng-dev
tooling. By adding the ability to validate a range of commit messages
together, the remaining piece of commit message validation that is in the
local version is replicated.
We use both commands provided by the `ng-dev commit-message` tooling:
- pre-commit-validate: Set to automatically run on an git hook to validate
commits as they are created locally.
- validate-range: Run by CI for every PR, testing that all of the commits
added by the PR are valid when considered together. Ensuring that all
fixups are matched to another commit in the change.
PR Close #36172
47 lines
1.7 KiB
TypeScript
47 lines
1.7 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
import * as yargs from 'yargs';
|
|
import {validateFile} from './validate-file';
|
|
import {validateCommitRange} from './validate-range';
|
|
|
|
/** Build the parser for the commit-message commands. */
|
|
export function buildCommitMessageParser(localYargs: yargs.Argv) {
|
|
return localYargs.help()
|
|
.strict()
|
|
.command(
|
|
'pre-commit-validate', 'Validate the most recent commit message', {},
|
|
() => {
|
|
validateFile('.git/COMMIT_EDITMSG');
|
|
})
|
|
.command(
|
|
'validate-range', 'Validate a range of commit messages', {
|
|
'range': {
|
|
description: 'The range of commits to check, e.g. --range abc123..xyz456',
|
|
demandOption: ' A range must be provided, e.g. --range abc123..xyz456',
|
|
type: 'string',
|
|
requiresArg: true,
|
|
},
|
|
},
|
|
argv => {
|
|
// If on CI, and not pull request number is provided, assume the branch
|
|
// being run on is an upstream branch.
|
|
if (process.env['CI'] && process.env['CI_PULL_REQUEST'] === 'false') {
|
|
console.info(
|
|
`Since valid commit messages are enforced by PR linting on CI, we do not\n` +
|
|
`need to validate commit messages on CI runs on upstream branches.\n\n` +
|
|
`Skipping check of provided commit range`);
|
|
return;
|
|
}
|
|
validateCommitRange(argv.range);
|
|
});
|
|
}
|
|
|
|
if (require.main == module) {
|
|
buildCommitMessageParser(yargs).parse();
|
|
}
|