008eaf3b7d
Close #41522 `zone.js` patches event listeners and run all event listeners together, if one event handler throws error, the listeners afterward may not be invoked. Reproduction: ``` export class AppComponent implements AfterViewInit { @ViewChild('btn') btn: ElementRef; title = 'event-error'; constructor(private ngZone: NgZone) {} ngAfterViewInit() { this.ngZone.runOutsideAngular(() => { this.btn.nativeElement.addEventListener('click', () => { throw new Error('test1'); }); this.btn.nativeElement.addEventListener('click', () => { console.log('add eventlistener click'); }); }); } } ``` Until now no Angular users report this issue becuase in the `ngZone`, all error will be caught and will not rethrow, so the event listeners afterward will still continue to execute, but if the event handlers are outside of `ngZone`, the error will break the execution. This commit catch all errors, and after all event listeners finished invocation, rethrow the errors in seperate `microTasks`, the reason I am using `microTask` here is to handle multiple errors case. PR Close #41562
25 lines
964 B
TypeScript
25 lines
964 B
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
Zone.__load_patch('socketio', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
|
|
(Zone as any)[Zone.__symbol__('socketio')] = function patchSocketIO(io: any) {
|
|
// patch io.Socket.prototype event listener related method
|
|
api.patchEventTarget(global, api, [io.Socket.prototype], {
|
|
useG: false,
|
|
chkDup: false,
|
|
rt: true,
|
|
diff: (task: any, delegate: any) => {
|
|
return task.callback === delegate;
|
|
}
|
|
});
|
|
// also patch io.Socket.prototype.on/off/removeListener/removeAllListeners
|
|
io.Socket.prototype.on = io.Socket.prototype.addEventListener;
|
|
io.Socket.prototype.off = io.Socket.prototype.removeListener =
|
|
io.Socket.prototype.removeAllListeners = io.Socket.prototype.removeEventListener;
|
|
};
|
|
});
|