angular-cn

History

George Kalpakas b4b21bdff4 fix(upgrade): fix HMR for hybrid applications (#40045 ) Previously, trying to apply a change via Hot Module Replacement (HMR) in a hybrid app would result in an error. This was caused by not having the AngularJS app destroyed and thus trying to bootstrap an AngularJS app on the same element twice. This commit fixes HMR for hybrid apps by ensuring the AngularJS app is destroyed when the Angular `PlatformRef` is [destroyed][1] in the [`module.hot.dispose()` callback][2]. NOTE: For "ngUpgradeLite" apps (i.e. those using `downgradeModule()`), HMR will only work if the downgraded module has been bootstrapped and there is at least one Angular component present on the page. The is due to a combination of two facts: - The logic for setting up the listener that destroys the AngularJS app depends on the downgraded module's `NgModuleRef`, which is only available after the module has been bootstrapped. - The [HMR dispose logic][3] depends on having an Angular element (identified by the auto-geenrated `ng-version` attribute) present in the DOM in order to retrieve the Angular `PlatformRef`. [1]: https://github.com/angular/angular-cli/blob/205ea2b638f154291993bfd9e065cd66ff20503/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts#L75 [2]: `205ea2b638/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts (L31)` [3]: `205ea2b638/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts (L116)` Fixes #39935 PR Close #40045		2020-12-10 13:40:53 -08:00
..
circular-deps	refactor(core): move `injectAttributeImpl` to avoid cycles (#37085 )	2020-11-19 12:19:42 -08:00
public-api	fix(upgrade): fix HMR for hybrid applications (#40045 )	2020-12-10 13:40:53 -08:00
size-tracking	fix(core): Support extending differs from root `NgModule` (#39981 )	2020-12-07 09:51:27 -08:00
BUILD.bazel	ci: migrate payload size tracking goldens to the golden directory (#36455 )	2020-04-24 09:05:11 -07:00
README.md	ci: set up golden file for typescript circular dependencies (#35647 )	2020-03-17 12:27:07 -07:00

README.md

`public-api/`

This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of the our bazel tests.

To check or update the public api goldens, run one of the following commands:

yarn public-api:check
yarn public-api:update

`packages-circular-deps.json`

This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.

To check or update the golden, run the following commands:

yarn ts-circular-deps:check
yarn ts-circular-deps:approve