Go to file
Alex Rickabaugh 13a0d527f6 fix(ivy): correctly write cross-file references (#25080)
There is a bug in the existing handling for cross-file references.
Suppose there are two files, module.ts and component.ts.

component.ts declares two components, one of which uses the other.
In the Ivy model, this means the component will get a directives:
reference to the other in its defineComponent call.

That reference is generated by looking at the declared components
of the module (in module.ts). However, the way ngtsc tracks this
reference, it ends up comparing the identifier of the component
in module.ts with the component.ts file, detecting they're not in
the same file, and generating a relative import.

This commit changes ngtsc to track all identifiers of a reference,
including the one by which it is declared. This allows toExpression()
to correctly decide that a local reference is okay in component.ts.

PR Close #25080
2018-07-26 16:38:09 -07:00
.circleci Revert "build: update to newer circleCI bazel remote cache proxy (#25054)" (#25076) 2018-07-24 16:05:58 -07:00
.github build: sync g3 exclude list from copybara to ngbot (#24224) 2018-05-31 10:07:45 -07:00
aio docs: refactor style guide example 03-06 (#24996) 2018-07-25 08:04:12 -07:00
docs ci: scripts to review PRs locally (#24623) 2018-06-25 08:45:12 -07:00
integration build(bazel): turn on preserve-symlinks (#24881) 2018-07-20 10:37:30 -07:00
modules build(bazel): fix broken travis CI (#24788) 2018-07-24 08:26:16 -07:00
packages fix(ivy): correctly write cross-file references (#25080) 2018-07-26 16:38:09 -07:00
scripts build: fix windows scripts (#23121) 2018-07-12 16:42:56 -04:00
tools Revert "feat(core): add support for using async/await with Jasmine" (#25096) 2018-07-25 11:44:56 -07:00
.bowerrc chore(dgeni): clean up legacy typings bundle creation 2015-10-29 21:19:59 +00:00
.clang-format feat(tooling): Add a .clang-format for automated JavaScript formatting. 2015-04-02 08:44:34 -07:00
.editorconfig chore(.editorconfig): include markdown config 2015-01-27 00:14:48 -08:00
.gitattributes chore: force lf EOL for ts files (#11143) 2016-08-29 12:41:58 -07:00
.gitignore build: update Bazel dependency to 0.11.1 (#23297) 2018-04-10 23:01:30 -07:00
.mailmap build: add a Git .mailmap with my new name (#19550) 2017-10-09 14:35:30 -07:00
.nvmrc build: update node version number in .nvmrc (#20832) 2017-12-12 11:56:18 -08:00
.pullapprove.yml ci: remove Tina from pullaprove (#25006) 2018-07-20 10:25:52 -07:00
.travis.yml ci: remove travis e2e_2 job (#22810) 2018-04-13 16:30:50 -07:00
BUILD.bazel build(bazel): //modules/benchmarks/src/largetable/render3:perf bazel protractor test (#24788) 2018-07-24 08:26:16 -07:00
CHANGELOG.md release: cut the v6.1.0 release 2018-07-25 14:23:40 -07:00
CODE_OF_CONDUCT.md docs: fix community tab in GitHub by copying CoC 2018-02-27 19:02:30 -08:00
CONTRIBUTING.md docs: change `aio` scope to `docs-infra` (#24410) 2018-06-12 11:36:14 -07:00
LICENSE docs(common): update copyright years (#21232) 2018-01-04 17:45:36 -05:00
README.md docs: improve the GitHub README.md, update links, etc 2018-05-03 13:26:12 -07:00
WORKSPACE build: Fix windows tests (#24927) 2018-07-20 10:51:32 -07:00
bower.json docs: branding fixes (#14132) 2017-01-27 15:03:11 -06:00
browser-providers.conf.js build: remove required BrowserStack run as it fails with “Access denied” (#19769) 2017-10-17 15:51:40 -07:00
build.sh build: upgrade jasmine (and related typings) to latest version (#19904) 2018-07-06 13:48:02 -07:00
gulpfile.js test: migrate remaining public-api tests to Bazel (#22639) 2018-03-09 09:11:40 -08:00
karma-js.conf.js refactor(ivy): run the compiler compliance tests against ngtsc (#24862) 2018-07-20 11:48:36 -07:00
package.json release: cut the v6.1.0 release 2018-07-25 14:23:40 -07:00
protractor-e2e.conf.js refactor: add license header to JS files & format files (#12081) 2016-10-04 20:39:20 -07:00
protractor-examples-e2e.conf.js refactor: format and lint code 2016-12-12 11:30:25 -08:00
protractor-perf.conf.js build(bazel): fix broken travis CI (#24788) 2018-07-24 08:26:16 -07:00
shims_for_IE.js Revert "refactor: add license header to JS files & format files (#12035)" 2016-10-04 14:06:41 -07:00
test-events.js fix(platform-browser): run BLACK_LISTED_EVENTS outside of ngZone (#18993) 2017-09-05 15:33:22 -05:00
test-main.js feat(core): upgrade rxjs to 6.0.0-alpha.4 (#22573) 2018-03-19 21:51:51 -07:00
test.sh feat: typescript 2.9 support (#24652) 2018-07-03 13:32:06 -07:00
tslint.json build: add lint rule for global flags in rollup config (#20028) 2017-10-30 23:09:16 -04:00
yarn.lock build: upgrade karma and related dependencies (#19904) 2018-07-06 13:48:02 -07:00
yarn.lock.readme.md build: switch from npm to yarn (#19328) 2017-09-22 13:20:52 -07:00

README.md

Build Status CircleCI BrowserStack Status Join the chat at https://gitter.im/angular/angular npm version

Angular

Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.

Quickstart

Get started in 5 minutes.

Changelog

Learn about the latest improvements.

Want to help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.