honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
angular-cn/packages/core/schematics/migrations
History
Paul Gschwendtner 59607dc495 fix(core): undecorated-classes-with-di migration should handle libraries generated with CLI versions past v6.2.0 (#35824) 
The options for `flatModuleId` and `flatModuleOutFile` had been removed in the CLI
from generated libraries with 718ee15b9a.

This has been done because `ng-packagr` (which is used to build the
libraries) automatically set these options in-memory when it compiles the library.
No migration has been created for this because there was no actual need to get rid of
this. Keeping the options in the library `tsconfig` does not cause any problems unless
the `tsconfig` is used outside of `ng-packagr`. This was not anticipated, but is now
commonly done in `ng update` migrations.

The `ng update` migrations try to create an instance of the `AngularCompilerProgram` by
simply parsing the `tsconfig`. The migrations make the valid assumption that `tsconfig` files
are not incomplete/invalid. They _definitely_ are in the file system though. It just works for
libraries because `ng-packagr` in-memory completes the invalid `tsconfig` files, so that they
can be passed to the `@angular/compiler-cli`.

We can't have this logic in the `ng update` migrations because it's
out-of-scope for individual migrations to distinguish between libraries
and applications. Also it would be out-of-scope to parse the
`ng-packagr` configuration and handle the tsconfig in-memory completion.

As a workaround though, we can remove the flat-module bundle options
in-memory when creating the compiler program. This is acceptable since
we don't emit the program and the flat module bundles are not needed.

Fixes #34985.

PR Close #35824
 		2020-03-06 12:40:18 -05:00
..
dynamic-queries refactor(core): update migrations descriptions (#33440) 2019-10-28 17:07:50 -07:00
google3 refactor(core): missing-injectable migration should respect providers of directives and components (#33011) 2019-10-14 20:24:01 +00:00
missing-injectable perf(ivy): reuse prior analysis work during incremental builds (#34288) 2019-12-12 13:11:45 -08:00
module-with-providers perf(ivy): reuse prior analysis work during incremental builds (#34288) 2019-12-12 13:11:45 -08:00
move-document refactor(core): add `createMigrationCompilerHost` (#32827) 2019-10-04 11:45:35 -07:00
renderer-to-renderer2 fix(core): renderer-to-renderer2 migration not migrating methods (#33571) 2019-11-05 22:05:17 +00:00
static-queries refactor(core): update migrations descriptions (#33440) 2019-10-28 17:07:50 -07:00
template-var-assignment refactor(core): update migrations descriptions (#33440) 2019-10-28 17:07:50 -07:00
undecorated-classes-with-decorated-fields refactor(core): update migrations descriptions (#33440) 2019-10-28 17:07:50 -07:00
undecorated-classes-with-di fix(core): undecorated-classes-with-di migration should handle libraries generated with CLI versions past v6.2.0 (#35824) 2020-03-06 12:40:18 -05:00