f690a4e0af
Our module resolution prefers `.js` files over `.d.ts` files because occasionally libraries publish their typings in the same directory structure as the compiled JS files, i.e. adjacent to each other. The standard TS module resolution would pick up the typings file and add that to the `ts.Program` and so they would be ignored by our analyzers. But we need those JS files, if they are part of the current package. But this meant that we also bring in JS files from external imports from outside the package, which is not desired. This was happening for the `@fire/storage` enty-point that was importing the `firebase/storage` path. In this commit we solve this problem, for the case of imports coming from a completely different package, by saying that any file that is outside the package root directory must be an external import and so we do not analyze those files. This does not solve the potential problem of imports between secondary entry-points within a package but so far that does not appear to be a problem. PR Close #30591
32 lines
1.2 KiB
TypeScript
32 lines
1.2 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
import * as ts from 'typescript';
|
|
import {absoluteFrom} from '../../../src/ngtsc/file_system';
|
|
import {runInEachFileSystem} from '../../../src/ngtsc/file_system/testing';
|
|
import {isWithinPackage} from '../../src/analysis/util';
|
|
|
|
runInEachFileSystem(() => {
|
|
describe('isWithinPackage', () => {
|
|
it('should return true if the source-file is contained in the package', () => {
|
|
const _ = absoluteFrom;
|
|
const file =
|
|
ts.createSourceFile(_('/node_modules/test/src/index.js'), '', ts.ScriptTarget.ES2015);
|
|
const packagePath = _('/node_modules/test');
|
|
expect(isWithinPackage(packagePath, file)).toBe(true);
|
|
});
|
|
|
|
it('should return false if the source-file is not contained in the package', () => {
|
|
const _ = absoluteFrom;
|
|
const file =
|
|
ts.createSourceFile(_('/node_modules/other/src/index.js'), '', ts.ScriptTarget.ES2015);
|
|
const packagePath = _('/node_modules/test');
|
|
expect(isWithinPackage(packagePath, file)).toBe(false);
|
|
});
|
|
});
|
|
});
|