a20b2f72f2
Prior to this commit, we had two different modes for change detection execution for Ivy, depending on whether you called `bootstrap()` or `renderComponent()`. In the former case, we would complete creation mode for all components in the tree before beginning update mode for any component. In the latter case, we would run creation mode and update mode together for each component individually. Maintaining code to support these two different execution orders was unnecessarily complex, so this commit aligns the two bootstrapping mechanisms to execute in the same order. Now creation mode always runs for all components before update mode begins. This change also simplifies our rendering logic so that we use `LView` flags as the source of truth for rendering mode instead of `rf` function arguments. This fixed some related bugs (e.g. calling `ViewRef.detectChanges` synchronously after the view's creation would create view nodes twice, view queries would execute twice, etc). PR Close #27744
76 lines
2.9 KiB
TypeScript
76 lines
2.9 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {devModeEqual} from '../change_detection/change_detection_util';
|
|
|
|
import {assertDataInRange, assertLessThan, assertNotEqual} from './assert';
|
|
import {throwErrorIfNoChangesMode} from './errors';
|
|
import {BINDING_INDEX, LView} from './interfaces/view';
|
|
import {getCheckNoChangesMode, isCreationMode} from './state';
|
|
import {NO_CHANGE} from './tokens';
|
|
import {isDifferent} from './util';
|
|
|
|
|
|
|
|
// TODO(misko): consider inlining
|
|
/** Updates binding and returns the value. */
|
|
export function updateBinding(lView: LView, bindingIndex: number, value: any): any {
|
|
return lView[bindingIndex] = value;
|
|
}
|
|
|
|
|
|
/** Gets the current binding value. */
|
|
export function getBinding(lView: LView, bindingIndex: number): any {
|
|
ngDevMode && assertDataInRange(lView, lView[bindingIndex]);
|
|
ngDevMode &&
|
|
assertNotEqual(lView[bindingIndex], NO_CHANGE, 'Stored value should never be NO_CHANGE.');
|
|
return lView[bindingIndex];
|
|
}
|
|
|
|
/** Updates binding if changed, then returns whether it was updated. */
|
|
export function bindingUpdated(lView: LView, bindingIndex: number, value: any): boolean {
|
|
ngDevMode && assertNotEqual(value, NO_CHANGE, 'Incoming value should never be NO_CHANGE.');
|
|
ngDevMode &&
|
|
assertLessThan(bindingIndex, lView.length, `Slot should have been initialized to NO_CHANGE`);
|
|
|
|
if (lView[bindingIndex] === NO_CHANGE) {
|
|
// initial pass
|
|
lView[bindingIndex] = value;
|
|
} else if (isDifferent(lView[bindingIndex], value)) {
|
|
if (ngDevMode && getCheckNoChangesMode()) {
|
|
if (!devModeEqual(lView[bindingIndex], value)) {
|
|
throwErrorIfNoChangesMode(isCreationMode(lView), lView[bindingIndex], value);
|
|
}
|
|
}
|
|
lView[bindingIndex] = value;
|
|
} else {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
/** Updates 2 bindings if changed, then returns whether either was updated. */
|
|
export function bindingUpdated2(lView: LView, bindingIndex: number, exp1: any, exp2: any): boolean {
|
|
const different = bindingUpdated(lView, bindingIndex, exp1);
|
|
return bindingUpdated(lView, bindingIndex + 1, exp2) || different;
|
|
}
|
|
|
|
/** Updates 3 bindings if changed, then returns whether any was updated. */
|
|
export function bindingUpdated3(
|
|
lView: LView, bindingIndex: number, exp1: any, exp2: any, exp3: any): boolean {
|
|
const different = bindingUpdated2(lView, bindingIndex, exp1, exp2);
|
|
return bindingUpdated(lView, bindingIndex + 2, exp3) || different;
|
|
}
|
|
|
|
/** Updates 4 bindings if changed, then returns whether any was updated. */
|
|
export function bindingUpdated4(
|
|
lView: LView, bindingIndex: number, exp1: any, exp2: any, exp3: any, exp4: any): boolean {
|
|
const different = bindingUpdated2(lView, bindingIndex, exp1, exp2);
|
|
return bindingUpdated2(lView, bindingIndex + 2, exp3, exp4) || different;
|
|
}
|