Go to file
Alex Rickabaugh 23b06af940 fix(core): export a value for InjectFlags (#27279)
A recent commit (probably 2c7386c) has changed the import graph of the
DI types in core, and somehow results in the ngc compiler deciding to
re-export core DI types from application factories which tangentially
use inject(). This is not really surprising; ngc's import graph can be
very unstable.

However, this results in a re-export of InjectFlags surviving JS
compilation. InjectFlags was a const enum, akin to an interface in TS,
with no runtime repesentation. This causes a warning to be emitted by
Webpack when it sees the re-export of InjectFlags.

This commit avoids the issue by removing 'const' from the declaration
of InjectFlags, causing it to have a runtime value. This is a temporary
fix. The real fix will be for ngc to no longer write exports of const
enums.

Testing strategy: manually verified. Due to the problem only manifesting
when recompiling after a change and then running Webpack, there is no
existing framework via which this could be easily tested with an
integration test. Additionally, the potential for this issue is gone in
Ivy, so this solution is only temporarily needed.

Fixes #27251.

PR Close #27279
2018-11-27 13:40:39 -08:00
.circleci build(ivy): remove the remains of ivy-jit mode (#27278) 2018-11-27 10:30:58 -08:00
.github build: fix size artifacts not measured by github robot (#27042) 2018-11-20 10:44:12 -08:00
aio build(docs-infra): upgrade `npm-run-all` to latest version for security (#27274) 2018-11-26 12:20:48 -08:00
docs build(ivy): remove the remains of ivy-jit mode (#27278) 2018-11-27 10:30:58 -08:00
integration fix(ivy): let ngcc transform @angular/core typings with relative imports (#27055) 2018-11-21 09:20:11 -08:00
modules build(bazel): upgrade benchmarks to protractor_web_test_suite for CI without local chrome (#26908) 2018-11-07 16:47:39 -08:00
packages fix(core): export a value for InjectFlags (#27279) 2018-11-27 13:40:39 -08:00
scripts build: update yarn version (#27193) 2018-11-21 07:46:22 -08:00
tools fix(core): export a value for InjectFlags (#27279) 2018-11-27 13:40:39 -08:00
.bazelignore build: add aio/tools/examples/shared/node_modules to .bazelignore (#27278) 2018-11-27 10:30:58 -08:00
.bazelrc build(ivy): remove the remains of ivy-jit mode (#27278) 2018-11-27 10:30:58 -08:00
.bowerrc chore(dgeni): clean up legacy typings bundle creation 2015-10-29 21:19:59 +00:00
.clang-format feat(tooling): Add a .clang-format for automated JavaScript formatting. 2015-04-02 08:44:34 -07:00
.editorconfig chore(.editorconfig): include markdown config 2015-01-27 00:14:48 -08:00
.gitattributes chore: force lf EOL for ts files (#11143) 2016-08-29 12:41:58 -07:00
.gitignore feat(bazel): Bazel workspace schematics (#26971) 2018-11-16 12:18:06 -08:00
.mailmap build: add a Git .mailmap with my new name (#19550) 2017-10-09 14:35:30 -07:00
.nvmrc build: update .nvmrc file to correct node version (#25992) 2018-09-18 13:11:58 -07:00
.pullapprove.yml ci: exclude symbol golden files from build-and-ci pullapprove group (#27004) 2018-11-08 13:10:53 -08:00
.travis.yml ci(docs-infra): remove jobs from Travis config (#26377) 2018-10-23 14:35:38 -07:00
BUILD.bazel build: use bazel version from node modules (#26691) 2018-10-30 16:19:13 -04:00
CHANGELOG.md release: cut the v7.1.0 release 2018-11-21 14:57:44 -08:00
CODE_OF_CONDUCT.md docs: fix community tab in GitHub by copying CoC 2018-02-27 19:02:30 -08:00
CONTRIBUTING.md docs: Indicate that PRs should have an associated issue (#25436) 2018-10-15 16:51:46 -07:00
LICENSE docs(common): update copyright years (#21232) 2018-01-04 17:45:36 -05:00
README.md build: run CI (#26488) 2018-10-19 20:59:29 -07:00
WORKSPACE build: update yarn version (#27193) 2018-11-21 07:46:22 -08:00
bower.json docs: branding fixes (#14132) 2017-01-27 15:03:11 -06:00
browser-providers.conf.js feat(elements): enable Shadow DOM v1 and slots (#24861) 2018-08-30 21:33:14 -07:00
build.sh feat(ivy): implement TestBed (#25369) 2018-08-14 11:58:47 -07:00
gulpfile.js style: update gulp task to format untracked and diff files separately (#24969) 2018-09-27 12:09:08 -07:00
index.bzl style: format .bzl files with buildifier (#23544) 2018-08-08 13:12:07 -07:00
karma-js.conf.js build(bazel): use fine-grained npm deps (#26111) (#26488) 2018-10-19 20:59:29 -07:00
package.json release: cut the v7.1.0 release 2018-11-21 14:57:44 -08:00
protractor-e2e.conf.js refactor: add license header to JS files & format files (#12081) 2016-10-04 20:39:20 -07:00
protractor-examples-e2e.conf.js refactor: format and lint code 2016-12-12 11:30:25 -08:00
protractor-perf.conf.js ci: configure chrome options for protractor (#26735) 2018-10-26 14:48:05 -04:00
shims_for_IE.js Revert "refactor: add license header to JS files & format files (#12035)" 2016-10-04 14:06:41 -07:00
test-events.js fix(platform-browser): run BLACK_LISTED_EVENTS outside of ngZone (#18993) 2017-09-05 15:33:22 -05:00
test-main.js refactor(core): remove withBody from public testing API (#25171) 2018-07-31 15:09:32 -07:00
test.sh feat: typescript 2.9 support (#24652) 2018-07-03 13:32:06 -07:00
tslint.json style: tslint enforces no debugger statements left behind (#25532) 2018-08-16 16:00:22 -07:00
yarn.lock build(bazel): Add Bazel builders (#27141) 2018-11-21 07:46:42 -08:00
yarn.lock.readme.md docs: replace npm with yarn in lockfile readme (#25309) 2018-08-06 13:38:13 -07:00

README.md

Build Status CircleCI BrowserStack Status Join the chat at https://gitter.im/angular/angular npm version

Angular

Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.

Quickstart

Get started in 5 minutes.

Changelog

Learn about the latest improvements.

Want to help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.