angular-cn

History

Andrew Kushnir 80c68583d1 refactor(core): use more narrow `QueryList` import to avoid circular deps issue (#36286 ) Prior to this commit, the `packages/core/src/render3/interfaces/query.ts` file used to import `QueryList` using `../../linker`, which contains a lot of re-exports and as a result, this one import caused a lot of circular deps cycles reported by the tool that checks such deps. In other places in the code the `QueryList` is imported using more narrow import (`linker/query_list`), so this commit uses the same pattern. This change allowed to reduce the number of known cycles from 343 to 207, the golden file was updated accordingly. PR Close #36286		2020-03-30 15:31:39 -07:00
..
public-api	fix(common): let `KeyValuePipe` accept type unions with `null` (#36093 )	2020-03-24 14:41:41 -07:00
BUILD.bazel	ci: move public-api goldens to goldens directory (#35768 )	2020-03-10 20:58:39 -04:00
README.md	ci: set up golden file for typescript circular dependencies (#35647 )	2020-03-17 12:27:07 -07:00
packages-circular-deps.json	refactor(core): use more narrow `QueryList` import to avoid circular deps issue (#36286 )	2020-03-30 15:31:39 -07:00

README.md

`public-api/`

This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of the our bazel tests.

To check or update the public api goldens, run one of the following commands:

yarn public-api:check
yarn public-api:update

`packages-circular-deps.json`

This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.

To check or update the golden, run the following commands:

yarn ts-circular-deps:check
yarn ts-circular-deps:approve