12cb39c1a4
This commit fixes an issue in the ivy native language service that caused the logic that finds a target node given a template position to throw away the results. This happened because the source span of a variable node in the shorthand structural directive syntax (i.e. `*ngIf=`) included the entire binding. The result was that we would add the variable node to the path and then later detect that the cursor was outside the key and value spans and throw away the whole result. In general, we do this because we do not want to show information when the cursor is between a key/value (`inputA=¦"123"`). However, when using the shorthand syntax, we run into the situation where we can match an `AttributeBinding` as well as the vaariable in `*ngIf="som¦eValue as myLocalVar"`. This commit updates the visitor to retain enough information in the visit path to throw away invalid targets but keep valid ones if there were multiple results on a `t.Element` or `t.Template`. PR Close #40239 |
||
|---|---|---|
| .. | ||
| BUILD.bazel | ||
| adapters_spec.ts | ||
| compiler_factory_spec.ts | ||
| daignostic_spec.ts | ||
| definitions_spec.ts | ||
| language_service_spec.ts | ||
| mock_host.ts | ||
| mock_host_spec.ts | ||
| template_target_spec.ts | ||
| test_utils.ts | ||
| type_definitions_spec.ts | ||