8e8e89a119
Previously, an instance of HttpParams would retain its list of mutations after they have been materialized as a result of a read operation. Not only does this unnecessarily hold onto memory, more importantly does it introduce a bug where branching of off a materialized instance would reconsider the set of mutations that had already been applied, resulting in repeated application of mutations. This commit fixes the bug by clearing the list of pending mutations after they have been materialized, such that they will not be considered once again for branched off instances. Fixes #20430 PR Close #29045
81 lines
2.8 KiB
TypeScript
81 lines
2.8 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {HttpParams} from '@angular/common/http/src/params';
|
|
|
|
{
|
|
describe('HttpUrlEncodedParams', () => {
|
|
describe('initialization', () => {
|
|
it('should be empty at construction', () => {
|
|
const body = new HttpParams();
|
|
expect(body.toString()).toEqual('');
|
|
});
|
|
|
|
it('should parse an existing url', () => {
|
|
const body = new HttpParams({fromString: 'a=b&c=d&c=e'});
|
|
expect(body.getAll('a')).toEqual(['b']);
|
|
expect(body.getAll('c')).toEqual(['d', 'e']);
|
|
});
|
|
});
|
|
|
|
describe('lazy mutation', () => {
|
|
it('should allow setting parameters', () => {
|
|
const body = new HttpParams({fromString: 'a=b'});
|
|
const mutated = body.set('a', 'c');
|
|
expect(mutated.toString()).toEqual('a=c');
|
|
});
|
|
|
|
it('should allow appending parameters', () => {
|
|
const body = new HttpParams({fromString: 'a=b'});
|
|
const mutated = body.append('a', 'c');
|
|
expect(mutated.toString()).toEqual('a=b&a=c');
|
|
});
|
|
|
|
it('should allow deletion of parameters', () => {
|
|
const body = new HttpParams({fromString: 'a=b&c=d&e=f'});
|
|
const mutated = body.delete('c');
|
|
expect(mutated.toString()).toEqual('a=b&e=f');
|
|
});
|
|
|
|
it('should allow chaining of mutations', () => {
|
|
const body = new HttpParams({fromString: 'a=b&c=d&e=f'});
|
|
const mutated = body.append('e', 'y').delete('c').set('a', 'x').append('e', 'z');
|
|
expect(mutated.toString()).toEqual('a=x&e=f&e=y&e=z');
|
|
});
|
|
|
|
it('should allow deletion of one value of a parameter', () => {
|
|
const body = new HttpParams({fromString: 'a=1&a=2&a=3&a=4&a=5'});
|
|
const mutated = body.delete('a', '2').delete('a', '4');
|
|
expect(mutated.getAll('a')).toEqual(['1', '3', '5']);
|
|
});
|
|
|
|
it('should not repeat mutations that have already been materialized', () => {
|
|
const body = new HttpParams({fromString: 'a=b'});
|
|
const mutated = body.append('a', 'c');
|
|
expect(mutated.toString()).toEqual('a=b&a=c');
|
|
const mutated2 = mutated.append('c', 'd');
|
|
expect(mutated.toString()).toEqual('a=b&a=c');
|
|
expect(mutated2.toString()).toEqual('a=b&a=c&c=d');
|
|
});
|
|
});
|
|
|
|
describe('read operations', () => {
|
|
it('should give null if parameter is not set', () => {
|
|
const body = new HttpParams({fromString: 'a=b&c=d'});
|
|
expect(body.get('e')).toBeNull();
|
|
expect(body.getAll('e')).toBeNull();
|
|
});
|
|
|
|
it('should give an accurate list of keys', () => {
|
|
const body = new HttpParams({fromString: 'a=1&b=2&c=3&d=4'});
|
|
expect(body.keys()).toEqual(['a', 'b', 'c', 'd']);
|
|
});
|
|
});
|
|
});
|
|
}
|