angular-cn/packages/core/schematics/migrations
Alan Agius 80394ce08b fix(core): TypeScript related migrations should cater for BOM (#30719)
fix(@schematics/angular): TypeScript related migrations should cater for BOM

In the CLI `UpdateRecorder` methods such as `insertLeft`, `remove` etc.. accepts positions which are not offset by a BOM. This is because when a file has a BOM a different recorder will be used https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/schematics/src/tree/recorder.ts#L72 which caters for an addition offset/delta.

The main reason for this is that when a developer is writing a schematic they shouldn't need to compute the offset based if a file has a BOM or not and is handled out of the box.

Example
```ts
recorder.insertLeft(5, 'true');
```

However this is unfortunate in the case if a ts SourceFile is used and one uses `getWidth` and `getStart` method they will already be offset by 1, which at the end it results in a double offset and hence the problem.

Fixes #30713

PR Close #30719
2019-05-30 20:48:45 -07:00
..
injectable-pipe fix(core): TypeScript related migrations should cater for BOM (#30719) 2019-05-30 20:48:45 -07:00
move-document fix(core): TypeScript related migrations should cater for BOM (#30719) 2019-05-30 20:48:45 -07:00
static-queries fix(core): TypeScript related migrations should cater for BOM (#30719) 2019-05-30 20:48:45 -07:00
template-var-assignment fix(core): TypeScript related migrations should cater for BOM (#30719) 2019-05-30 20:48:45 -07:00