angular-cn/packages/core/test/linker
Alex Rickabaugh bb290cefae fix(core): make QueryList implement Iterable in the type system (#33536)
Originally, QueryList implemented Iterable and provided a Symbol.iterator
on its prototype. This caused issues with tree-shaking, so QueryList was
refactored and the Symbol.iterator added in its constructor instead. As
part of this change, QueryList no longer implemented Iterable directly.

Unfortunately, this meant that QueryList was no longer assignable to
Iterable or, consequently, NgIterable. NgIterable is used for NgFor's input,
so this meant that QueryList was not usable (in a type sense) for NgFor
iteration. View Engine's template type checking would not catch this, but
Ivy's did.

As a fix, this commit adds the declaration (but not the implementation) of
the Symbol.iterator function back to QueryList. This has no runtime effect,
so it doesn't affect tree-shaking of QueryList, but it ensures that
QueryList is assignable to NgIterable and thus usable with NgFor.

Fixes #29842

PR Close #33536
2019-11-19 13:43:53 -08:00
..
change_detection_integration_spec.ts refactor(compiler): add details while throw error during expression convert (#32760) 2019-11-18 15:47:59 -08:00
entry_components_integration_spec.ts test(ivy): ComponentFactoryResolver can resolve any component factory in Ivy (#28465) 2019-01-31 15:55:31 -05:00
inheritance_integration_spec.ts fix(ivy): proper component resolution in case of inheritance (#28439) 2019-02-05 23:29:04 -05:00
integration_spec.ts fix(ivy): shadow all DOM properties in `DebugElement.properties` (#33781) 2019-11-18 15:49:22 -08:00
jit_summaries_integration_spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
ng_container_integration_spec.ts feat(ivy): i18n - reorganize entry-points for better reuse (#32488) 2019-09-12 15:35:34 -07:00
ng_module_integration_spec.ts revert: fix(ivy): R3TestBed should clean up registered modules after each test (#32872) (#33663) 2019-11-12 09:53:16 -08:00
projection_integration_spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
query_integration_spec.ts test: clean up explicit dynamic query usages (#33015) 2019-10-17 16:10:10 -04:00
query_list_spec.ts fix(core): make QueryList implement Iterable in the type system (#33536) 2019-11-19 13:43:53 -08:00
regression_integration_spec.ts refactor(core): move Meta methods that only have one version from DomAdapter (#32408) 2019-09-03 11:59:39 -07:00
security_integration_spec.ts fix(ivy): warn instead of throwing for unknown properties (#32463) 2019-09-06 13:15:03 -04:00
source_map_integration_node_only_spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
system_ng_module_factory_loader_spec.ts fix(ivy): don't load factories when using Ivy (#28685) 2019-04-12 11:26:24 -07:00
view_injector_integration_spec.ts test(ivy): run view_injector_integration tests on node (#28593) 2019-02-08 09:25:50 -08:00