d68ad3e617
A constructor function may have been "synthesized" by TypeScript during JavaScript emit, in the case no user-defined constructor exists and e.g. property initializers are used. Those initializers need to be emitted into a constructor in JavaScript, so the TypeScript compiler generates a synthetic constructor. This commit adds identification of such constructors as ngcc needs to be able to tell if a class did originally have a constructor in the TypeScript source. When a class has a superclass, a synthesized constructor must not be considered as a user-defined constructor as that prevents a base factory call from being created by ngtsc, resulting in a factory function that does not inject the dependencies of the superclass. Hence, we identify a default synthesized super call in the constructor body, according to the structure that TypeScript emits. PR Close #27897 |
||
|---|---|---|
| .. | ||
| bazel | ||
| bazel-schematics | ||
| cli-hello-world | ||
| cli-hello-world-ivy | ||
| dynamic-compiler | ||
| hello_world__closure | ||
| hello_world__systemjs_umd | ||
| i18n | ||
| injectable-def | ||
| language_service_plugin | ||
| ng_elements | ||
| ng_update | ||
| ngcc | ||
| platform-server | ||
| typings_test_ts31 | ||
| typings_test_ts32 | ||
| .gitignore | ||
| README.md | ||
| _payload-limits.json | ||
| get-sharded-tests.js | ||
| run_tests.sh | ||
README.md
Integration tests for Angular
This directory contains end-to-end tests for Angular. Each directory is a self-contained application that exactly mimics how a user might expect Angular to work, so they allow high-fidelity reproductions of real-world issues.
For this to work, we first build the Angular distribution just like we would publish it to npm, then install the distribution into each app.
To test Angular CLI applications, we use the integration test cli-hello-world.
When a significant change is released in the CLI, the application should be updated with ng update:
$ cd integration/cli-hello-world
$ yarn install
$ yarn ng update @angular/cli @angular-devkit/build-angular
# yarn build
# yarn test
# typescript version
Render3 tests
The directory hello_world_cli contains a test for render3 used with the angular cli.
If the Angular CLI is modified to generate a render3 application this should be replaced with that project.
If the render3 is updated to support the Angular 5 bootstrap a version of this project should be created that uses the Angular 5 bootstrap.
Writing an integration test
The API for each test is:
- Each sub-directory here is an integration test
- Each test should have a
package.jsonfile - The test runner will run
yarnandyarn teston the package
This means that the test should be started by test script, like
"scripts": {"test": "runProgramA && assertResultIsGood"}
Note that the package.json file uses a special file://../../dist scheme
to reference the Angular packages, so that the locally-built Angular
is installed into the test app.
Also, beware of floating (non-locked) dependencies. If in doubt
you can install the package directly from file:../../node_modules.
Running integration tests
$ ./integration/run_tests.sh
The test runner will first re-build any stale npm packages, then cd into each
subdirectory to execute the test.