honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
angular-cn/packages
History
Paul Gschwendtner 58436fd81a fix(ivy): unable to import shim factory files on case-insensitive platforms (#28831) 
This change is kind of similar to #27466, but instead of ensuring that
these shims can be generated, we also need to make sure that developers
are able to also use the factory shims like with `ngc`.

This issue is now surfacing because we have various old examples which
are now also built with `ngtsc`  (due to the bazel migration). On case insensitive
platforms (e.g. windows) these examples cannot be built because ngtsc fails
the app imports a generated shim file (such as the factory shim files).

This is because the `GeneratedShimsHostWrapper` TypeScript host uses
the `getCanonicalFileName` method in order to check whether a given
file/module exists in the generator file maps. e.g.

```
// Generator Map:
'C:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ngfactory.ts' =>
'C:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ts',

// Path passed into `fileExists`
C:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ngfactory.ts

// After getCanonicalFileName (notice the **lower-case drive name**)
c:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ngfactory.ts
```

As seen above, the generator map does not use the canonical file names, as well as
TypeScript internally does not pass around canonical file names. We can fix this by removing
the manual call to `getCanonicalFileName` and just following TypeScript internal-semantics.

PR Close #28831
 		2019-02-20 18:26:05 -08:00
..
animations build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
bazel refactor(bazel): Schematics should fetch angular from distro (#28851) 2019-02-20 09:01:44 -08:00
benchpress feat: optionally save complete performance log in chrome benchpress tests (#27551) 2019-02-05 23:35:32 -05:00
common feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings (#28711) 2019-02-20 13:46:15 -08:00
compiler fix(ivy): support static ContentChild queries (#28811) 2019-02-19 15:29:01 -08:00
compiler-cli fix(ivy): unable to import shim factory files on case-insensitive platforms (#28831) 2019-02-20 18:26:05 -08:00
core feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings (#28711) 2019-02-20 13:46:15 -08:00
docs refactor: move angular source to /packages rather than modules/@angular 2017-03-08 16:29:27 -08:00
elements build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
examples build: run example unit tests with bazel (#28703) 2019-02-20 16:31:48 -08:00
forms build(bazel): do not build rxjs from source under Bazel (#28720) 2019-02-19 16:28:14 -08:00
http build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
language-service build(bazel): do not build rxjs from source under Bazel (#28720) 2019-02-19 16:28:14 -08:00
platform-browser build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
platform-browser-dynamic build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
platform-server build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
platform-webworker build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
platform-webworker-dynamic build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
private/testing build: run playground e2e examples with bazel (#28490) 2019-02-04 16:51:11 -05:00
router build(bazel): do not build rxjs from source under Bazel (#28720) 2019-02-19 16:28:14 -08:00
service-worker build: enable bundle_dts for a number of packages (#28726) 2019-02-19 16:30:38 -08:00
upgrade build(bazel): do not build rxjs from source under Bazel (#28720) 2019-02-19 16:28:14 -08:00
BUILD.bazel build(bazel): specify tsconfig-test dependency (#28696) 2019-02-16 20:57:34 -08:00
README.md Revert "docs: Remove unneeded file (#18106)" 2017-07-20 16:46:47 -05:00
empty.ts refactor: move angular source to /packages rather than modules/@angular 2017-03-08 16:29:27 -08:00
goog.d.ts test(ivy): add bundling test `todo_i18n` (#27420) 2018-12-04 19:59:12 -08:00
license-banner.txt build: bump year (#27880) 2019-01-11 11:15:59 -08:00
system.d.ts refactor: move angular source to /packages rather than modules/@angular 2017-03-08 16:29:27 -08:00
tsconfig-build.json build(bazel): Turning on strictPropertyInitialization for Angular. (#24572) 2018-06-25 07:57:13 -07:00
tsconfig-test.json build: refactor ambient node & jasmine types so they are only included where needed (#25491) 2018-08-16 13:46:43 -07:00
tsconfig.json build: switch example e2e tests to bazel (#28402) 2019-01-28 19:21:09 -08:00
types.d.ts build: switch to typescript's es2015 typings (#28570) 2019-02-06 14:17:55 -05:00

README.md

Angular

The sources for this package are in the main Angular repo. Please file issues and pull requests against that repo.

License: MIT