angular-cn/modules
Paul Gschwendtner 5a257d02a6 build: fix "person_management" playground example (#28490)
Currently when someone serves the "person_management" playground
example, there will be runtime exceptions by `@angular/forms` if
someone clicks on one of the two buttons rendered in the example.

This happens because the example is outdated and the input elements
using `ngModel` do not specify a proper "name" while being inside of
a `<form>` element. A name is required inside of a form. The failure
is not specific to Ivy and is not covered by any test because the e2e
tests for this example are just asserting that the page properly loads
(the error only shows up one of the buttons has been clicked)

This is the reason why these errors were never visibile to the e2e tests.
Though in order to make this example work, we should this fix these failures
so that the example can work as expected.

```
FullNameComponent.html:7 ERROR Error: If ngModel is used within a form tag, either the name attribute must be set or the form
      control must be defined as 'standalone' in ngModelOptions.

      Example 1: <input [(ngModel)]="person.firstName" name="first">
      Example 2: <input [(ngModel)]="person.firstName" [ngModelOptions]="{standalone: true}">
    at Function.TemplateDrivenErrors.missingNameException (template_driven_errors.ts:40)
    at NgModel._checkName (ng_model.ts:319)
    at NgModel._checkForErrors (ng_model.ts:302)
    at NgModel.ngOnChanges (ng_model.ts:215)
    at Object.checkAndUpdateDirectiveInline (provider.ts:208)
    at checkAndUpdateNodeInline (view.ts:429)
    at checkAndUpdateNode (view.ts:389)
    at debugCheckAndUpdateNode (services.ts:431)
    at debugCheckDirectivesFn (services.ts:392)
    at Object.eval [as updateDirectives] (FullNameComponent.html:7)
```

PR Close #28490
2019-02-04 16:51:11 -05:00
..
angular1_router build: update npm dependencies (#19328) 2017-09-22 13:20:52 -07:00
benchmarks build: remove travisci leftovers (#27979) 2019-01-09 10:41:16 -08:00
benchmarks_external test: remove bower and polymer benchmarks (#27931) 2019-01-04 12:02:22 -08:00
e2e_util fix(ivy): update largetable benchmark to use ngFor (#26604) 2018-10-22 10:37:02 -07:00
payload_tests/hello_world/ts docs: branding fixes (#14132) 2017-01-27 15:03:11 -06:00
playground build: fix "person_management" playground example (#28490) 2019-02-04 16:51:11 -05:00
build.sh ci: move e2e tests from travis to circleci (#27937) 2019-01-07 15:35:09 -08:00
empty.ts refactor: update paths from modules/@angular to packages 2017-03-08 16:29:28 -08:00
es6-subset.d.ts refactor: update paths from modules/@angular to packages 2017-03-08 16:29:28 -08:00
system.d.ts refactor: update paths from modules/@angular to packages 2017-03-08 16:29:28 -08:00
tsconfig.json build: switch playground examples to bazel (#28490) 2019-02-04 16:51:11 -05:00
types.d.ts build: upgrade `@types/jasminewd2` to 2.0.4 (#26139) 2018-10-12 14:11:11 -07:00