angular-cn/packages/core/schematics
Paul Gschwendtner 8d3365e4fc fix(core): static-query usage migration strategy should detect ambiguous query usage (#30215)
Currently we always just set the timing to `false` if we aren't
able to analyze a given call expression or new expression. e.g.

```ts
ngOnInit() {
  thirdPartyCallSync(() => this.query.doSomething())
}
```

In that case the `thirdPartyCallSync` function comes from the `node_modules`
and is only defined through types while there is no code for the
actual function logic that can be analyzed. This makes it impossible
to tell whether the given call expression actually causes the specified
arrow function to be executed synchronously or not. In order to be able
to make this better, we now peek into the passed arrow function and
check for a synchronous query usage. If so, we set the query timing to
static and mark it as ambiguous. This ensures that the usage strategy is
less "magical" and more correct with third-party code.

Additionally since functions like `setTimeout` are not analyzable but known
to be asynchronous, there is a hard-coded list of known functions which
shouldn't be marked as ambiguous.

Resolves FW-1214. As planned within https://hackmd.io/hPiLWpPlQ4uynC1luIBdfQ

PR Close #30215
2019-05-09 14:39:06 -07:00
..
migrations fix(core): static-query usage migration strategy should detect ambiguous query usage (#30215) 2019-05-09 14:39:06 -07:00
test fix(core): static-query usage migration strategy should detect ambiguous query usage (#30215) 2019-05-09 14:39:06 -07:00
utils fix(core): static-query migration should not prompt if no queries are used (#30254) 2019-05-08 09:22:48 -07:00
BUILD.bazel test(core): run schematic tests with public migration collection (#30198) 2019-05-08 09:23:28 -07:00
migrations.json fix: disable injectable-pipe migration (#30180) 2019-04-29 09:40:00 -07:00
tsconfig.json refactor(core): add static-query template strategy (#29815) 2019-04-15 10:53:54 -07:00