Previously we only logged a warning if we attempted to auto-link to a doc that had no `path` property, which implies that it is private and is not rendered. Now we fail hard during full doc-gen, although when running the `yarn serv-and-sync` command it should not fail if changes are only made to guides, which is what authors who use this tool are most likely to do. PR Close #40404
		
			
				
	
	
		
			209 lines
		
	
	
		
			9.3 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			209 lines
		
	
	
		
			9.3 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| var createTestPackage = require('../../helpers/test-package');
 | |
| var Dgeni = require('dgeni');
 | |
| 
 | |
| describe('autoLinkCode post-processor', () => {
 | |
|   let processor, autoLinkCode, aliasMap, filterPipes, log;
 | |
| 
 | |
|   beforeEach(() => {
 | |
|     const testPackage = createTestPackage('angular-base-package');
 | |
|     const dgeni = new Dgeni([testPackage]);
 | |
|     const injector = dgeni.configureInjector();
 | |
|     autoLinkCode = injector.get('autoLinkCode');
 | |
|     autoLinkCode.docTypes = ['class', 'pipe', 'function', 'const', 'member'];
 | |
|     aliasMap = injector.get('aliasMap');
 | |
|     processor = injector.get('postProcessHtml');
 | |
|     processor.docTypes = ['test-doc'];
 | |
|     processor.plugins = [autoLinkCode];
 | |
|     filterPipes = injector.get('filterPipes');
 | |
|     log = injector.get('log');
 | |
|   });
 | |
| 
 | |
|   it('should insert an anchor into every code item that matches the id of an API doc', () => {
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code>MyClass</code>'};
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent)
 | |
|         .toEqual('<code><a href="a/b/myclass" class="code-anchor">MyClass</a></code>');
 | |
|   });
 | |
| 
 | |
|   it('should insert an anchor into every code item that matches an alias of an API doc', () => {
 | |
|     aliasMap.addDoc({
 | |
|       docType: 'class',
 | |
|       id: 'MyClass',
 | |
|       aliases: ['MyClass', 'foo.MyClass'],
 | |
|       path: 'a/b/myclass'
 | |
|     });
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code>foo.MyClass</code>'};
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent)
 | |
|         .toEqual('<code><a href="a/b/myclass" class="code-anchor">foo.MyClass</a></code>');
 | |
|   });
 | |
| 
 | |
|   it('should match code items within a block of code that contain a dot in their identifier',
 | |
|      () => {
 | |
|        aliasMap.addDoc({
 | |
|          docType: 'member',
 | |
|          id: 'MyEnum.Value',
 | |
|          aliases: ['Value', 'MyEnum.Value'],
 | |
|          path: 'a/b/myenum'
 | |
|        });
 | |
|        const doc = {docType: 'test-doc', renderedContent: '<code>someFn(): MyEnum.Value</code>'};
 | |
|        processor.$process([doc]);
 | |
|        expect(doc.renderedContent)
 | |
|            .toEqual(
 | |
|                '<code>someFn(): <a href="a/b/myenum" class="code-anchor">MyEnum.Value</a></code>');
 | |
|      });
 | |
| 
 | |
|   it('should ignore code items that do not match a link to an API doc', () => {
 | |
|     aliasMap.addDoc({docType: 'guide', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code>MyClass</code>'};
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent).toEqual('<code>MyClass</code>');
 | |
|   });
 | |
| 
 | |
|   it('should ignore code items that are already inside a link', () => {
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     const doc = {
 | |
|       docType: 'test-doc',
 | |
|       renderedContent: '<a href="..."><div><code>MyClass</code></div></a>'
 | |
|     };
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent).toEqual('<a href="..."><div><code>MyClass</code></div></a>');
 | |
|   });
 | |
| 
 | |
|   it('should ignore code items match an API doc but are not in the list of acceptable docTypes',
 | |
|      () => {
 | |
|        aliasMap.addDoc(
 | |
|            {docType: 'directive', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|        const doc = {docType: 'test-doc', renderedContent: '<code>MyClass</code>'};
 | |
|        processor.$process([doc]);
 | |
|        expect(doc.renderedContent).toEqual('<code>MyClass</code>');
 | |
|      });
 | |
| 
 | |
|   it('should ignore code items that match an API doc but are attached to other text via a dash',
 | |
|      () => {
 | |
|        aliasMap.addDoc(
 | |
|            {docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|        const doc = {docType: 'test-doc', renderedContent: '<code>xyz-MyClass</code>'};
 | |
|        processor.$process([doc]);
 | |
|        expect(doc.renderedContent).toEqual('<code>xyz-MyClass</code>');
 | |
|      });
 | |
| 
 | |
|   it('should ignore code items that are filtered out by custom filters', () => {
 | |
|     autoLinkCode.customFilters = [filterPipes];
 | |
|     aliasMap.addDoc({
 | |
|       docType: 'pipe',
 | |
|       id: 'MyClass',
 | |
|       aliases: ['MyClass', 'myClass'],
 | |
|       path: 'a/b/myclass',
 | |
|       pipeOptions: {name: '\'myClass\''}
 | |
|     });
 | |
|     const doc = {
 | |
|       docType: 'test-doc',
 | |
|       renderedContent:
 | |
|           '<code>{ xyz | myClass } { xyz|myClass } MyClass myClass OtherClass|MyClass</code>'
 | |
|     };
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent)
 | |
|         .toEqual(
 | |
|             '<code>' +
 | |
|             '{ xyz | <a href="a/b/myclass" class="code-anchor">myClass</a> } ' +
 | |
|             '{ xyz|<a href="a/b/myclass" class="code-anchor">myClass</a> } ' +
 | |
|             '<a href="a/b/myclass" class="code-anchor">MyClass</a> ' +
 | |
|             'myClass OtherClass|<a href="a/b/myclass" class="code-anchor">MyClass</a>' +
 | |
|             '</code>');
 | |
|   });
 | |
| 
 | |
|   it('should ignore code items that match an internal API doc', () => {
 | |
|     aliasMap.addDoc({
 | |
|       docType: 'class',
 | |
|       id: 'MyClass',
 | |
|       aliases: ['MyClass'],
 | |
|       path: 'a/b/myclass',
 | |
|       internal: true
 | |
|     });
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code>MyClass</code>'};
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent).toEqual('<code>MyClass</code>');
 | |
|   });
 | |
| 
 | |
|   it('should ignore documents when the `docType` is set to `member` and the keyword doesn\'t include `.`',
 | |
|      () => {
 | |
|        aliasMap.addDoc({docType: 'member', id: 'MyEnum', aliases: ['MyEnum'], path: 'a/b/c'});
 | |
|        const doc = {docType: 'test-doc', renderedContent: '<code>MyEnum</code>'};
 | |
|        processor.$process([doc]);
 | |
|        expect(doc.renderedContent).toEqual('<code>MyEnum</code>');
 | |
|      });
 | |
| 
 | |
|   it('should insert anchors for individual text nodes within a code block', () => {
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     const doc = {
 | |
|       docType: 'test-doc',
 | |
|       renderedContent: '<code><span>MyClass</span><span>MyClass</span></code>'
 | |
|     };
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent)
 | |
|         .toEqual(
 | |
|             '<code><span><a href="a/b/myclass" class="code-anchor">MyClass</a></span><span><a href="a/b/myclass" class="code-anchor">MyClass</a></span></code>');
 | |
|   });
 | |
| 
 | |
|   it('should insert anchors for words that match within text nodes in a code block', () => {
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     aliasMap.addDoc({docType: 'function', id: 'myFunc', aliases: ['myFunc'], path: 'ng/myfunc'});
 | |
|     aliasMap.addDoc({docType: 'const', id: 'MY_CONST', aliases: ['MY_CONST'], path: 'ng/my_const'});
 | |
|     const doc = {
 | |
|       docType: 'test-doc',
 | |
|       renderedContent: '<code>myFunc() {\n  return new MyClass(MY_CONST);\n}</code>'
 | |
|     };
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent)
 | |
|         .toEqual(
 | |
|             '<code><a href="ng/myfunc" class="code-anchor">myFunc</a>() {\n  return new <a href="a/b/myclass" class="code-anchor">MyClass</a>(<a href="ng/my_const" class="code-anchor">MY_CONST</a>);\n}</code>');
 | |
|   });
 | |
| 
 | |
|   it('should work with custom elements', () => {
 | |
|     autoLinkCode.codeElements = ['code-example'];
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code-example>MyClass</code-example>'};
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent)
 | |
|         .toEqual(
 | |
|             '<code-example><a href="a/b/myclass" class="code-anchor">MyClass</a></code-example>');
 | |
|   });
 | |
| 
 | |
|   it('should ignore code blocks that are marked with a `no-auto-link` class', () => {
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code class="no-auto-link">MyClass</code>'};
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent).toEqual('<code class="no-auto-link">MyClass</code>');
 | |
|   });
 | |
| 
 | |
|   it('should ignore code blocks that are marked with an "ignored" language', () => {
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass'], path: 'a/b/myclass'});
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code language="bash">MyClass</code>'};
 | |
|     processor.$process([doc]);
 | |
|     expect(doc.renderedContent).toEqual('<code language="bash">MyClass</code>');
 | |
|   });
 | |
| 
 | |
|   it('should record a warning if the autolinked doc has no `path` and `failOnMissingDocPath` is false',
 | |
|      () => {
 | |
|        aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass']});
 | |
|        const doc = {docType: 'test-doc', renderedContent: '<code>MyClass</code>'};
 | |
|        autoLinkCode.failOnMissingDocPath = false;
 | |
|        processor.$process([doc]);
 | |
| 
 | |
|        expect(log.warn).toHaveBeenCalledWith(`
 | |
|       autoLinkCode: Doc path is empty for "MyClass" - link will not be generated for "MyClass".
 | |
|       Please make sure if the doc should be public. If not, it should probably not be referenced in the docs. - doc (test-doc) `);
 | |
|      });
 | |
| 
 | |
|   it('should fail if the autolinked doc has no `path` and `failOnMissingDocPath` is true', () => {
 | |
|     aliasMap.addDoc({docType: 'class', id: 'MyClass', aliases: ['MyClass']});
 | |
|     const doc = {docType: 'test-doc', renderedContent: '<code>MyClass</code>'};
 | |
|     autoLinkCode.failOnMissingDocPath = true;
 | |
|     expect(() => processor.$process([doc])).toThrowError(`
 | |
|       autoLinkCode: Doc path is empty for "MyClass" - link will not be generated for "MyClass".
 | |
|       Please make sure if the doc should be public. If not, it should probably not be referenced in the docs. - doc (test-doc) `);
 | |
|   });
 | |
| });
 |