angular-cn/packages/language-service
ayazhafiz ee46b9b44f fix(language-service): correctly parse expressions in an attribute (#34517)
Currently, the language service provides completions in a template node
attribute by first checking if the attribute contains template bindings
to provide completions for, and then providing completions for the
expression in the attribute.

In the latter case, the expression AST was being constructed
"synthetically" inside the language service, in particular declaring the
expression to be a `PropertyRead` with an implicit receiver.
Unfortunately, this AST can be incorrect if the expression is actually a
property read on a component property receiver (e.g. when reading
`key` in the expression `obj.key`, `obj` is the receiver).

The fix is pretty simple - rather than a synthetic construction of the
AST, ask the expression parser to parse the expression in the attribute.

Fixes https://github.com/angular/vscode-ng-language-service/issues/523

PR Close #34517
2020-01-06 11:37:21 -08:00
..
bundles fix(language-service): Simplify resolution logic in banner (#34262) 2019-12-06 10:27:30 -08:00
src fix(language-service): correctly parse expressions in an attribute (#34517) 2020-01-06 11:37:21 -08:00
test fix(language-service): correctly parse expressions in an attribute (#34517) 2020-01-06 11:37:21 -08:00
BUILD.bazel build: remove deps on legacy nodejs rules rollup_bundle internals (#33201) (#33607) 2019-11-06 19:56:57 +00:00
index.ts build: roll up to named .js files rather than 'index.js' (#19190) 2017-09-19 16:59:18 -07:00
language-service.ts build: refactor ambient node & jasmine types so they are only included where needed (#25491) 2018-08-16 13:46:43 -07:00
package.json build: set up all packages to publish via wombot proxy (#33747) 2019-11-13 11:34:33 -08:00