honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
10,841 Commits 5 Branches 1 Tag 210 MiB
TypeScript 68.6%
HTML 12.8%
JavaScript 8.4%
Pug 7%
Starlark 1.4%
Other 1.7%
Go to file
Vikram Subramanian 6b859daea4 fix(core): stop reusing provider definitions across NgModuleRef instances (#25022) 
Fixes #25018.

Instantiating a NgModuleRef from NgModuleFactory reuses the NgModuleDefinition if it is already present. However the NgModuleDefinition has a providers array which modified when tree shakable providers are instantiated. This corrupts the provider definitions the next time the same factory is used to create a new NgModuleRef - Two provider definitions can end up with the same index anf the injector could potentially return a completely wrong object for a provider token.

This scenario is more likely on the server where the same NgModuleFactory is reused across requests.

The fix clones the cached NgModuleDefinition so that any tree shakable providers added later do not affect the cached copy.

PR Close #25022
 		2018-07-23 08:13:29 -07:00
.circleci build: update to Bazel 0.15 (#24841) 2018-07-13 15:05:16 -04:00
.github build: sync g3 exclude list from copybara to ngbot (#24224) 2018-05-31 10:07:45 -07:00
aio docs: add api doc to commonly queried elements 2018-07-20 12:39:10 -07:00
docs ci: scripts to review PRs locally (#24623) 2018-06-25 08:45:12 -07:00
integration build(bazel): turn on preserve-symlinks (#24881) 2018-07-20 10:37:30 -07:00
modules feat(ivy): properly apply class="", [class], [class.foo] and [attr.class] bindings (#24822) 2018-07-17 16:33:25 -04:00
packages fix(core): stop reusing provider definitions across NgModuleRef instances (#25022) 2018-07-23 08:13:29 -07:00
scripts build: fix windows scripts (#23121) 2018-07-12 16:42:56 -04:00
tools fix(ivy): correctly export all *Def symbols as private (#24862) 2018-07-20 11:48:36 -07:00
.bowerrc chore(dgeni): clean up legacy typings bundle creation 2015-10-29 21:19:59 +00:00
.clang-format feat(tooling): Add a .clang-format for automated JavaScript formatting. 2015-04-02 08:44:34 -07:00
.editorconfig chore(.editorconfig): include markdown config 2015-01-27 00:14:48 -08:00
.gitattributes chore: force lf EOL for ts files (#11143) 2016-08-29 12:41:58 -07:00
.gitignore build: update Bazel dependency to 0.11.1 (#23297) 2018-04-10 23:01:30 -07:00
.mailmap build: add a Git .mailmap with my new name (#19550) 2017-10-09 14:35:30 -07:00
.nvmrc build: update node version number in .nvmrc (#20832) 2017-12-12 11:56:18 -08:00
.pullapprove.yml ci: remove Tina from pullaprove (#25006) 2018-07-20 10:25:52 -07:00
.travis.yml ci: remove travis e2e_2 job (#22810) 2018-04-13 16:30:50 -07:00
BUILD.bazel build(bazel): turn on preserve-symlinks (#24881) 2018-07-20 10:37:30 -07:00
CHANGELOG.md release: cut the v6.1.0-rc.3 release 2018-07-19 15:45:06 -07:00
CODE_OF_CONDUCT.md docs: fix community tab in GitHub by copying CoC 2018-02-27 19:02:30 -08:00
CONTRIBUTING.md docs: change `aio` scope to `docs-infra` (#24410) 2018-06-12 11:36:14 -07:00
LICENSE docs(common): update copyright years (#21232) 2018-01-04 17:45:36 -05:00
README.md docs: improve the GitHub README.md, update links, etc 2018-05-03 13:26:12 -07:00
WORKSPACE build: Fix windows tests (#24927) 2018-07-20 10:51:32 -07:00
bower.json docs: branding fixes (#14132) 2017-01-27 15:03:11 -06:00
browser-providers.conf.js build: remove required BrowserStack run as it fails with “Access denied” (#19769) 2017-10-17 15:51:40 -07:00
build.sh build: upgrade jasmine (and related typings) to latest version (#19904) 2018-07-06 13:48:02 -07:00
gulpfile.js test: migrate remaining public-api tests to Bazel (#22639) 2018-03-09 09:11:40 -08:00
karma-js.conf.js refactor(ivy): run the compiler compliance tests against ngtsc (#24862) 2018-07-20 11:48:36 -07:00
package.json release: cut the v6.1.0-rc.3 release 2018-07-19 15:45:06 -07:00
protractor-e2e.conf.js refactor: add license header to JS files & format files (#12081) 2016-10-04 20:39:20 -07:00
protractor-examples-e2e.conf.js refactor: format and lint code 2016-12-12 11:30:25 -08:00
protractor-perf.conf.js refactor: add license header to JS files & format files (#12081) 2016-10-04 20:39:20 -07:00
shims_for_IE.js Revert "refactor: add license header to JS files & format files (#12035)" 2016-10-04 14:06:41 -07:00
test-events.js fix(platform-browser): run BLACK_LISTED_EVENTS outside of ngZone (#18993) 2017-09-05 15:33:22 -05:00
test-main.js feat(core): upgrade rxjs to 6.0.0-alpha.4 (#22573) 2018-03-19 21:51:51 -07:00
test.sh feat: typescript 2.9 support (#24652) 2018-07-03 13:32:06 -07:00
tslint.json build: add lint rule for global flags in rollup config (#20028) 2017-10-30 23:09:16 -04:00
yarn.lock build: upgrade karma and related dependencies (#19904) 2018-07-06 13:48:02 -07:00
yarn.lock.readme.md build: switch from npm to yarn (#19328) 2017-09-22 13:20:52 -07:00

README.md

Build Status CircleCI BrowserStack Status Join the chat at https://gitter.im/angular/angular npm version

Angular

Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.

Quickstart

Get started in 5 minutes.

Changelog

Learn about the latest improvements.

Want to help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.