2021ad12cf
The angular.io production deployment script (`deploy-to-firebase.sh`) compares the major version corresponding to the current branch (e.g. `8` for branch `8.1.x`) against the major stable version (e.g. `9` if the current stable version is `9.1.0`). It then uses the result of that comparison to determine whether the current branch corresponds to a newer version than stable (i.e. an RC version) and thus should not be deployed or to an older version and thus may need to be deployed to an archive vX.angular.io project. Previously, the script was using string comparison (`<`) to compare the two major versions. This could produce incorrect results for an RC major version that is numerically greater than the stable but lexicographically smaller. For example, 10 vs 9 (10 is numerically greater but lexicographically smaller than 9). Example of a CI job that incorrectly tried to deploy an RC branch to production: https://circleci.com/gh/angular/angular/726414 This commit fixes it by switching to an integer comparison (i.e. using the `-lt` operator). PR Close #37426
115 lines
3.6 KiB
Bash
Executable File
115 lines
3.6 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# WARNING: CI_SECRET_AIO_DEPLOY_FIREBASE_TOKEN should NOT be printed.
|
|
set +x -eu -o pipefail
|
|
|
|
# Do not deploy if we are running in a fork.
|
|
if [[ "$CI_REPO_OWNER/$CI_REPO_NAME" != "angular/angular" ]]; then
|
|
echo "Skipping deploy because this is not angular/angular."
|
|
exit 0
|
|
fi
|
|
|
|
# Do not deploy if this is a PR. PRs are deployed in the `aio_preview` CircleCI job.
|
|
if [[ $CI_PULL_REQUEST != "false" ]]; then
|
|
echo "Skipping deploy because this is a PR build."
|
|
exit 0
|
|
fi
|
|
|
|
# Do not deploy if the current commit is not the latest on its branch.
|
|
readonly latestCommit=$(git ls-remote origin $CI_BRANCH | cut -c1-40)
|
|
if [[ $CI_COMMIT != $latestCommit ]]; then
|
|
echo "Skipping deploy because $CI_COMMIT is not the latest commit ($latestCommit)."
|
|
exit 0
|
|
fi
|
|
|
|
# The deployment mode is computed based on the branch we are building
|
|
if [[ $CI_BRANCH == master ]]; then
|
|
readonly deployEnv=next
|
|
elif [[ $CI_BRANCH == $CI_STABLE_BRANCH ]]; then
|
|
readonly deployEnv=stable
|
|
else
|
|
# Extract the major versions from the branches, e.g. the 4 from 4.3.x
|
|
readonly majorVersion=${CI_BRANCH%%.*}
|
|
readonly majorVersionStable=${CI_STABLE_BRANCH%%.*}
|
|
|
|
# Do not deploy if the major version is not less than the stable branch major version
|
|
if [[ !( "$majorVersion" -lt "$majorVersionStable" ) ]]; then
|
|
echo "Skipping deploy of branch \"$CI_BRANCH\" to firebase."
|
|
echo "We only deploy archive branches with the major version less than the stable branch: \"$CI_STABLE_BRANCH\""
|
|
exit 0
|
|
fi
|
|
|
|
# Find the branch that has highest minor version for the given `$majorVersion`
|
|
readonly mostRecentMinorVersion=$(
|
|
# List the branches that start with the major version
|
|
git ls-remote origin refs/heads/${majorVersion}.*.x |
|
|
# Extract the version number
|
|
awk -F'/' '{print $3}' |
|
|
# Sort by the minor version
|
|
sort -t. -k 2,2n |
|
|
# Get the highest version
|
|
tail -n1
|
|
)
|
|
|
|
# Do not deploy as it is not the latest branch for the given major version
|
|
if [[ $CI_BRANCH != $mostRecentMinorVersion ]]; then
|
|
echo "Skipping deploy of branch \"$CI_BRANCH\" to firebase."
|
|
echo "There is a more recent branch with the same major version: \"$mostRecentMinorVersion\""
|
|
exit 0
|
|
fi
|
|
|
|
readonly deployEnv=archive
|
|
fi
|
|
|
|
case $deployEnv in
|
|
next)
|
|
readonly projectId=aio-staging
|
|
readonly deployedUrl=https://next.angular.io/
|
|
readonly firebaseToken=$CI_SECRET_AIO_DEPLOY_FIREBASE_TOKEN
|
|
;;
|
|
stable)
|
|
readonly projectId=angular-io
|
|
readonly deployedUrl=https://angular.io/
|
|
readonly firebaseToken=$CI_SECRET_AIO_DEPLOY_FIREBASE_TOKEN
|
|
;;
|
|
archive)
|
|
readonly projectId=v${majorVersion}-angular-io
|
|
readonly deployedUrl=https://v${majorVersion}.angular.io/
|
|
readonly firebaseToken=$CI_SECRET_AIO_DEPLOY_FIREBASE_TOKEN
|
|
;;
|
|
esac
|
|
|
|
echo "Git branch : $CI_BRANCH"
|
|
echo "Build/deploy mode : $deployEnv"
|
|
echo "Firebase project : $projectId"
|
|
echo "Deployment URL : $deployedUrl"
|
|
|
|
if [[ ${1:-} == "--dry-run" ]]; then
|
|
exit 0
|
|
fi
|
|
|
|
# Deploy
|
|
(
|
|
cd "`dirname $0`/.."
|
|
|
|
# Build the app
|
|
yarn build --configuration=$deployEnv --progress=false
|
|
|
|
# Include any mode-specific files
|
|
cp -rf src/extra-files/$deployEnv/. dist/
|
|
|
|
# Set deployedUrl as parameter in the opensearch description
|
|
# deployedUrl must end with /
|
|
yarn set-opensearch-url $deployedUrl
|
|
|
|
# Check payload size
|
|
yarn payload-size
|
|
|
|
# Deploy to Firebase
|
|
yarn firebase use "$projectId" --token "$firebaseToken"
|
|
yarn firebase deploy --message "Commit: $CI_COMMIT" --non-interactive --token "$firebaseToken"
|
|
|
|
# Run PWA-score tests
|
|
yarn test-pwa-score "$deployedUrl" "$CI_AIO_MIN_PWA_SCORE"
|
|
)
|