779344012a
This PR provides a more helpful error than the one currently present: `el.setAttribute is not a function`. It is not valid to have directives with host bindings on `ng-template` or `ng-container` nodes. VE would silently ignore this, while Ivy attempts to set the attribute and throws an error because these are comment nodes and do not have `setAttribute` functionality. It is better to throw a helpful error than to silently ignore this because putting a directive with host binding on an `ng-template` or `ng-container` is most often a mistake. Developers should be made aware that the host binding will have no effect in these cases. Note that an error is already thrown in Ivy, as mentioned above, so this is not a breaking change and can be merged to both master and patch. Resolves #35994 PR Close #37111
70 lines
1.9 KiB
JSON
70 lines
1.9 KiB
JSON
{
|
|
"cli-hello-world": {
|
|
"master": {
|
|
"uncompressed": {
|
|
"runtime-es2015": 1485,
|
|
"main-es2015": 142590,
|
|
"polyfills-es2015": 36963
|
|
}
|
|
}
|
|
},
|
|
"cli-hello-world-ivy-minimal": {
|
|
"master": {
|
|
"uncompressed": {
|
|
"runtime-es2015": 1485,
|
|
"main-es2015": 16959,
|
|
"polyfills-es2015": 36657
|
|
}
|
|
}
|
|
},
|
|
"cli-hello-world-ivy-compat": {
|
|
"master": {
|
|
"uncompressed": {
|
|
"runtime-es2015": 1485,
|
|
"main-es2015": 148510,
|
|
"polyfills-es2015": 36963
|
|
}
|
|
}
|
|
},
|
|
"cli-hello-world-ivy-i18n": {
|
|
"master": {
|
|
"uncompressed": {
|
|
"runtime-es2015": 1485,
|
|
"main-es2015": 138196,
|
|
"polyfills-es2015": 37640
|
|
}
|
|
}
|
|
},
|
|
"cli-hello-world-lazy": {
|
|
"master": {
|
|
"uncompressed": {
|
|
"runtime-es2015": 2289,
|
|
"main-es2015": 247942,
|
|
"polyfills-es2015": 36657,
|
|
"5-es2015": 751
|
|
}
|
|
}
|
|
},
|
|
"cli-hello-world-lazy-rollup": {
|
|
"master": {
|
|
"uncompressed": {
|
|
"runtime-es2015": 2289,
|
|
"main-es2015": 223603,
|
|
"polyfills-es2015": 36657,
|
|
"5-es2015": 779
|
|
}
|
|
}
|
|
},
|
|
"hello_world__closure": {
|
|
"master": {
|
|
"uncompressed": {
|
|
"bundle": "TODO(i): temporarily increase the payload size limit from 105779 - this is due to a closure issue related to ESM reexports that still needs to be investigated",
|
|
"bundle": "TODO(i): we should define ngDevMode to false in Closure, but --define only works in the global scope.",
|
|
"bundle": "TODO(i): (FW-2164) TS 3.9 new class shape seems to have broken Closure in big ways. The size went from 169991 to 252338",
|
|
"bundle": "TODO(i): after removal of tsickle from ngc-wrapped / ng_package, we had to switch to SIMPLE optimizations which increased the size from 252338 to 1197869, see PR#37221 and PR#37317 for more info",
|
|
"bundle": 1198831
|
|
}
|
|
}
|
|
}
|
|
}
|