779344012a
This PR provides a more helpful error than the one currently present: `el.setAttribute is not a function`. It is not valid to have directives with host bindings on `ng-template` or `ng-container` nodes. VE would silently ignore this, while Ivy attempts to set the attribute and throws an error because these are comment nodes and do not have `setAttribute` functionality. It is better to throw a helpful error than to silently ignore this because putting a directive with host binding on an `ng-template` or `ng-container` is most often a mistake. Developers should be made aware that the host binding will have no effect in these cases. Note that an error is already thrown in Ivy, as mentioned above, so this is not a breaking change and can be merged to both master and patch. Resolves #35994 PR Close #37111 |
||
|---|---|---|
| .. | ||
| circular-deps | ||
| public-api | ||
| size-tracking | ||
| BUILD.bazel | ||
| README.md | ||
README.md
public-api/
This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of the our bazel tests.
To check or update the public api goldens, run one of the following commands:
yarn public-api:check
yarn public-api:update
packages-circular-deps.json
This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.
To check or update the golden, run the following commands:
yarn ts-circular-deps:check
yarn ts-circular-deps:approve