In view_container.js, templateElement.parentNode can be null when two template tags are nested in one another. Accessing the parent node through view.nodes[0].parentNode fixes the problem. closes #997 Closes #999
		
			
				
	
	
		
			245 lines
		
	
	
		
			8.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			245 lines
		
	
	
		
			8.8 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| import {
 | |
|   AsyncTestCompleter,
 | |
|   beforeEach,
 | |
|   ddescribe,
 | |
|   describe,
 | |
|   el,
 | |
|   expect,
 | |
|   iit,
 | |
|   inject,
 | |
|   IS_DARTIUM,
 | |
|   it,
 | |
|   xit,
 | |
| } from 'angular2/test_lib';
 | |
| 
 | |
| import {DOM} from 'angular2/src/dom/dom_adapter';
 | |
| 
 | |
| import {Injector} from 'angular2/di';
 | |
| import {Lexer, Parser, ChangeDetector, dynamicChangeDetection} from 'angular2/change_detection';
 | |
| 
 | |
| import {Compiler, CompilerCache} from 'angular2/src/core/compiler/compiler';
 | |
| import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader';
 | |
| import {NativeShadowDomStrategy} from 'angular2/src/core/compiler/shadow_dom_strategy';
 | |
| import {TemplateLoader} from 'angular2/src/core/compiler/template_loader';
 | |
| import {ComponentUrlMapper} from 'angular2/src/core/compiler/component_url_mapper';
 | |
| import {UrlResolver} from 'angular2/src/core/compiler/url_resolver';
 | |
| import {StyleUrlResolver} from 'angular2/src/core/compiler/style_url_resolver';
 | |
| import {CssProcessor} from 'angular2/src/core/compiler/css_processor';
 | |
| 
 | |
| import {Component} from 'angular2/src/core/annotations/annotations';
 | |
| import {Template} from 'angular2/src/core/annotations/template';
 | |
| 
 | |
| import {MockTemplateResolver} from 'angular2/src/mock/template_resolver_mock';
 | |
| 
 | |
| import {If} from 'angular2/src/directives/if';
 | |
| 
 | |
| export function main() {
 | |
|   describe('if directive', () => {
 | |
|     var view, cd, compiler, component, tplResolver;
 | |
| 
 | |
|     beforeEach(() => {
 | |
|       var urlResolver = new UrlResolver();
 | |
|       tplResolver = new MockTemplateResolver();
 | |
|       compiler = new Compiler(
 | |
|         dynamicChangeDetection,
 | |
|         new TemplateLoader(null, null),
 | |
|         new DirectiveMetadataReader(),
 | |
|         new Parser(new Lexer()),
 | |
|         new CompilerCache(),
 | |
|         new NativeShadowDomStrategy(new StyleUrlResolver(urlResolver)),
 | |
|         tplResolver,
 | |
|         new ComponentUrlMapper(),
 | |
|         urlResolver,
 | |
|         new CssProcessor(null)
 | |
|       );
 | |
|     });
 | |
| 
 | |
|     function createView(pv) {
 | |
|       component = new TestComponent();
 | |
|       view = pv.instantiate(null, null);
 | |
|       view.hydrate(new Injector([]), null, null, component, null);
 | |
|       cd = view.changeDetector;
 | |
|     }
 | |
| 
 | |
|     function compileWithTemplate(html) {
 | |
|       var template = new Template({
 | |
|         inline: html,
 | |
|         directives: [If]
 | |
|       });
 | |
|       tplResolver.setTemplate(TestComponent, template);
 | |
|       return compiler.compile(TestComponent);
 | |
|     }
 | |
| 
 | |
|     it('should work in a template attribute', inject([AsyncTestCompleter], (async) => {
 | |
|       compileWithTemplate('<div><copy-me template="if booleanCondition">hello</copy-me></div>').then((pv) => {
 | |
|         createView(pv);
 | |
|         cd.detectChanges();
 | |
| 
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('hello');
 | |
|         async.done();
 | |
|       });
 | |
|     }));
 | |
| 
 | |
|     it('should work in a template element', inject([AsyncTestCompleter], (async) => {
 | |
|       compileWithTemplate('<div><template [if]="booleanCondition"><copy-me>hello2</copy-me></template></div>').then((pv) => {
 | |
|         createView(pv);
 | |
|         cd.detectChanges();
 | |
| 
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('hello2');
 | |
|         async.done();
 | |
|       });
 | |
|     }));
 | |
| 
 | |
|     it('should toggle node when condition changes', inject([AsyncTestCompleter], (async) => {
 | |
|       compileWithTemplate('<div><copy-me template="if booleanCondition">hello</copy-me></div>').then((pv) => {
 | |
|         createView(pv);
 | |
| 
 | |
|         component.booleanCondition = false;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(0);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('');
 | |
| 
 | |
| 
 | |
|         component.booleanCondition = true;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('hello');
 | |
| 
 | |
|         component.booleanCondition = false;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(0);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('');
 | |
| 
 | |
|         async.done();
 | |
|       });
 | |
|     }));
 | |
| 
 | |
|     it('should handle nested if correctly', inject([AsyncTestCompleter], (async) => {
 | |
|       compileWithTemplate('<div><template [if]="booleanCondition"><copy-me *if="nestedBooleanCondition">hello</copy-me></template></div>').then((pv) => {
 | |
|         createView(pv);
 | |
| 
 | |
|         component.booleanCondition = false;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(0);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('');
 | |
| 
 | |
|         component.booleanCondition = true;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('hello');
 | |
| 
 | |
|         component.nestedBooleanCondition = false;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(0);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('');
 | |
| 
 | |
|         component.nestedBooleanCondition = true;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('hello');
 | |
| 
 | |
|         component.booleanCondition = false;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(0);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('');
 | |
| 
 | |
|         async.done();
 | |
|       });
 | |
|     }));
 | |
| 
 | |
|     it('should update several nodes with if', inject([AsyncTestCompleter], (async) => {
 | |
|       var templateString =
 | |
|       '<div>' +
 | |
|         '<copy-me template="if numberCondition + 1 >= 2">helloNumber</copy-me>' +
 | |
|         '<copy-me template="if stringCondition == \'foo\'">helloString</copy-me>' +
 | |
|         '<copy-me template="if functionCondition(stringCondition, numberCondition)">helloFunction</copy-me>' +
 | |
|       '</div>';
 | |
|       compileWithTemplate(templateString).then((pv) => {
 | |
|         createView(pv);
 | |
| 
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(3);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('helloNumberhelloStringhelloFunction');
 | |
| 
 | |
|         component.numberCondition = 0;
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('helloString');
 | |
| 
 | |
|         component.numberCondition = 1;
 | |
|         component.stringCondition = "bar";
 | |
|         cd.detectChanges();
 | |
|         expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|         expect(DOM.getText(view.nodes[0])).toEqual('helloNumber');
 | |
|         async.done();
 | |
|       });
 | |
|     }));
 | |
| 
 | |
| 
 | |
|     if (!IS_DARTIUM) {;
 | |
|       it('should not add the element twice if the condition goes from true to true (JS)', inject([AsyncTestCompleter], (async) => {
 | |
|         compileWithTemplate('<div><copy-me template="if numberCondition">hello</copy-me></div>').then((pv) => {
 | |
|           createView(pv);
 | |
| 
 | |
|           cd.detectChanges();
 | |
|           expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|           expect(DOM.getText(view.nodes[0])).toEqual('hello');
 | |
| 
 | |
|           component.numberCondition = 2;
 | |
|           cd.detectChanges();
 | |
|           expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(1);
 | |
|           expect(DOM.getText(view.nodes[0])).toEqual('hello');
 | |
| 
 | |
|           async.done();
 | |
|         });
 | |
|       }));
 | |
| 
 | |
|       it('should not recreate the element if the condition goes from true to true (JS)', inject([AsyncTestCompleter], (async) => {
 | |
|         compileWithTemplate('<div><copy-me template="if numberCondition">hello</copy-me></div>').then((pv) => {
 | |
|           createView(pv);
 | |
| 
 | |
|           cd.detectChanges();
 | |
|           DOM.addClass(view.nodes[0].childNodes[1], "foo");
 | |
| 
 | |
|           component.numberCondition = 2;
 | |
|           cd.detectChanges();
 | |
|           expect(DOM.hasClass(view.nodes[0].childNodes[1], "foo")).toBe(true);
 | |
| 
 | |
|           async.done();
 | |
|         });
 | |
|       }));
 | |
|     } else {
 | |
|       it('should not create the element if the condition is not a boolean (DART)', inject([AsyncTestCompleter], (async) => {
 | |
|         compileWithTemplate('<div><copy-me template="if numberCondition">hello</copy-me></div>').then((pv) => {
 | |
|           createView(pv);
 | |
|           expect(function(){cd.detectChanges();}).toThrowError();
 | |
|           expect(DOM.querySelectorAll(view.nodes[0], 'copy-me').length).toEqual(0);
 | |
|           expect(DOM.getText(view.nodes[0])).toEqual('');
 | |
|           async.done();
 | |
|         });
 | |
|       }));
 | |
|     }
 | |
| 
 | |
|   });
 | |
| }
 | |
| 
 | |
| @Component({selector: 'test-cmp'})
 | |
| class TestComponent {
 | |
|   booleanCondition: boolean;
 | |
|   nestedBooleanCondition: boolean;
 | |
|   numberCondition: number;
 | |
|   stringCondition: string;
 | |
|   functionCondition: Function;
 | |
|   constructor() {
 | |
|     this.booleanCondition = true;
 | |
|     this.nestedBooleanCondition = true;
 | |
|     this.numberCondition = 1;
 | |
|     this.stringCondition = "foo";
 | |
|     this.functionCondition = function(s, n){
 | |
|       return s == "foo" && n == 1;
 | |
|     };
 | |
|   }
 | |
| }
 |