angular-cn/packages/core/schematics/migrations/undecorated-classes-with-di
Paul Gschwendtner 59607dc495 fix(core): undecorated-classes-with-di migration should handle libraries generated with CLI versions past v6.2.0 (#35824)
The options for `flatModuleId` and `flatModuleOutFile` had been removed in the CLI
from generated libraries with 718ee15b9a.

This has been done because `ng-packagr` (which is used to build the
libraries) automatically set these options in-memory when it compiles the library.
No migration has been created for this because there was no actual need to get rid of
this. Keeping the options in the library `tsconfig` does not cause any problems unless
the `tsconfig` is used outside of `ng-packagr`. This was not anticipated, but is now
commonly done in `ng update` migrations.

The `ng update` migrations try to create an instance of the `AngularCompilerProgram` by
simply parsing the `tsconfig`. The migrations make the valid assumption that `tsconfig` files
are not incomplete/invalid. They _definitely_ are in the file system though. It just works for
libraries because `ng-packagr` in-memory completes the invalid `tsconfig` files, so that they
can be passed to the `@angular/compiler-cli`.

We can't have this logic in the `ng update` migrations because it's
out-of-scope for individual migrations to distinguish between libraries
and applications. Also it would be out-of-scope to parse the
`ng-packagr` configuration and handle the tsconfig in-memory completion.

As a workaround though, we can remove the flat-module bundle options
in-memory when creating the compiler program. This is acceptable since
we don't emit the program and the flat module bundles are not needed.

Fixes #34985.

PR Close #35824
2020-03-06 12:40:18 -05:00
..
decorator_rewrite refactor(core): undecorated-classes migration should properly construct object literal from metadata (#32319) 2019-08-28 17:11:36 -07:00
BUILD.bazel feat(core): add undecorated classes migration schematic (#31650) 2019-08-13 14:40:52 -07:00
create_ngc_program.ts fix(core): undecorated-classes-with-di migration should handle libraries generated with CLI versions past v6.2.0 (#35824) 2020-03-06 12:40:18 -05:00
find_base_classes.ts feat(core): add undecorated classes migration schematic (#31650) 2019-08-13 14:40:52 -07:00
import_manager.ts feat(core): add undecorated classes migration schematic (#31650) 2019-08-13 14:40:52 -07:00
index.ts perf(ivy): reuse prior analysis work during incremental builds (#34288) 2019-12-12 13:11:45 -08:00
ng_declaration_collector.ts feat(core): add undecorated classes migration schematic (#31650) 2019-08-13 14:40:52 -07:00
transform.ts fix(language-service): create StaticReflector once only (#32543) 2019-10-03 15:02:03 -07:00
update_recorder.ts feat(core): add undecorated classes migration schematic (#31650) 2019-08-13 14:40:52 -07:00