10e29355db
Previously, if `UmdRenderingFormatter#addImports()` was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, function arguments, function parameters), thus making the code imcompatible with legacy browsers such as IE11. This commit fixes it by ensuring that no trailing commas are added if `addImports()` is called with an empty list of imports. This is a follow-up to #34353. Fixes #34525 PR Close #34545
178 lines
9.0 KiB
Bash
Executable File
178 lines
9.0 KiB
Bash
Executable File
#!/bin/bash
|
||
|
||
# Do not immediately exit on error to allow the `assertSucceeded` function to handle the error.
|
||
#
|
||
# NOTE:
|
||
# Each statement should be followed by an `assertSucceeded`/`assertFailed` or `exit 1` statement.
|
||
set +e -x
|
||
|
||
PATH=$PATH:$(npm bin)
|
||
|
||
function assertFailed {
|
||
if [[ $? -eq 0 ]]; then
|
||
echo "FAIL: $1";
|
||
exit 1;
|
||
fi
|
||
}
|
||
|
||
function assertSucceeded {
|
||
if [[ $? -ne 0 ]]; then
|
||
echo "FAIL: $1";
|
||
exit 1;
|
||
fi
|
||
}
|
||
|
||
|
||
ngcc --help
|
||
assertSucceeded "Expected 'ngcc --help' to succeed."
|
||
|
||
# node --inspect-brk $(npm bin)/ngcc -f esm2015
|
||
# Run ngcc and check it logged compilation output as expected
|
||
ngcc | grep 'Compiling'
|
||
assertSucceeded "Expected 'ngcc' to log 'Compiling'."
|
||
|
||
|
||
# Did it add the appropriate build markers?
|
||
|
||
# - esm2015
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"esm2015": "'
|
||
assertSucceeded "Expected 'ngcc' to add build marker for 'esm2015' in '@angular/common'."
|
||
|
||
# - fesm2015
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"fesm2015": "'
|
||
assertSucceeded "Expected 'ngcc' to add build marker for 'fesm2015' in '@angular/common'."
|
||
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"es2015": "'
|
||
assertSucceeded "Expected 'ngcc' to add build marker for 'es2015' in '@angular/common'."
|
||
|
||
# - esm5
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"esm5": "'
|
||
assertSucceeded "Expected 'ngcc' to add build marker for 'esm5' in '@angular/common'."
|
||
|
||
# - fesm5
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"module": "'
|
||
assertSucceeded "Expected 'ngcc' to add build marker for 'module' in '@angular/common'."
|
||
|
||
cat node_modules/@angular/common/package.json | awk 'ORS=" "' | grep '"__processed_by_ivy_ngcc__":[^}]*"fesm5": "'
|
||
assertSucceeded "Expected 'ngcc' to add build marker for 'fesm5' in '@angular/common'."
|
||
|
||
|
||
# Did it replace the PRE_R3 markers correctly?
|
||
grep "= SWITCH_COMPILE_COMPONENT__POST_R3__" node_modules/@angular/core/fesm2015/core.js
|
||
assertSucceeded "Expected 'ngcc' to replace 'SWITCH_COMPILE_COMPONENT__PRE_R3__' in '@angular/core' (fesm2015)."
|
||
|
||
grep "= SWITCH_COMPILE_COMPONENT__POST_R3__" node_modules/@angular/core/fesm5/core.js
|
||
assertSucceeded "Expected 'ngcc' to replace 'SWITCH_COMPILE_COMPONENT__PRE_R3__' in '@angular/core' (fesm5)."
|
||
|
||
|
||
# Did it compile @angular/core/ApplicationModule correctly?
|
||
grep "ApplicationModule.ɵmod = ɵɵdefineNgModule" node_modules/@angular/core/fesm2015/core.js
|
||
assertSucceeded "Expected 'ngcc' to correctly compile 'ApplicationModule' in '@angular/core' (fesm2015)."
|
||
|
||
grep "ApplicationModule.ɵmod = ɵɵdefineNgModule" node_modules/@angular/core/fesm5/core.js
|
||
assertSucceeded "Expected 'ngcc' to correctly compile 'ApplicationModule' in '@angular/core' (fesm5)."
|
||
|
||
grep "ApplicationModule.ɵmod = ɵngcc0.ɵɵdefineNgModule" node_modules/@angular/core/esm2015/src/application_module.js
|
||
assertSucceeded "Expected 'ngcc' to correctly compile 'ApplicationModule' in '@angular/core' (esm2015)."
|
||
|
||
grep "ApplicationModule.ɵmod = ɵngcc0.ɵɵdefineNgModule" node_modules/@angular/core/esm5/src/application_module.js
|
||
assertSucceeded "Expected 'ngcc' to correctly compile 'ApplicationModule' in '@angular/core' (esm5)."
|
||
|
||
# Did it place the `setClassMetadata` call correctly?
|
||
cat node_modules/@angular/core/fesm2015/core.js | awk 'ORS=" "' | grep "ApplicationRef.ctorParameters.*setClassMetadata(ApplicationRef"
|
||
assertSucceeded "Expected 'ngcc' to place 'setClassMetadata' after static properties like 'ctorParameters' in '@angular/core' (fesm2015)."
|
||
|
||
|
||
# Did it transform @angular/core typing files correctly?
|
||
grep "import [*] as ɵngcc0 from './src/r3_symbols';" node_modules/@angular/core/core.d.ts
|
||
assertSucceeded "Expected 'ngcc' to add an import for 'src/r3_symbols' in '@angular/core' typings."
|
||
|
||
grep "static ɵinj: ɵngcc0.ɵɵInjectorDef<ApplicationModule>;" node_modules/@angular/core/core.d.ts
|
||
assertSucceeded "Expected 'ngcc' to add a definition for 'ApplicationModule.ɵinj' in '@angular/core' typings."
|
||
|
||
|
||
# Did it generate a base factory call for synthesized constructors correctly?
|
||
grep "const ɵMatTable_BaseFactory = ɵngcc0.ɵɵgetInheritedFactory(MatTable);" node_modules/@angular/material/esm2015/table/table.js
|
||
assertSucceeded "Expected 'ngcc' to generate a base factory for 'MatTable' in '@angular/material' (esm2015)."
|
||
|
||
grep "var ɵMatTable_BaseFactory = ɵngcc0.ɵɵgetInheritedFactory(MatTable);" node_modules/@angular/material/esm5/table/table.js
|
||
assertSucceeded "Expected 'ngcc' to generate a base factory for 'MatTable' in '@angular/material' (esm5)."
|
||
|
||
|
||
# Did it generate an abstract directive definition for undecorated classes with inputs and view queries?
|
||
grep "_MatMenuBase.ɵdir = ɵngcc0.ɵɵdefineDirective({ type: _MatMenuBase" node_modules/@angular/material/esm2015/menu/menu.js
|
||
assertSucceeded "Expected 'ngcc' to generate an abstract directive definition for 'MatMenuBase' in '@angular/material' (esm2015)."
|
||
|
||
grep "_MatMenuBase.ɵdir = ɵngcc0.ɵɵdefineDirective({ type: _MatMenuBase" node_modules/@angular/material/esm5/menu/menu.js
|
||
assertSucceeded "Expected 'ngcc' to generate an abstract directive definition for 'MatMenuBase' in '@angular/material' (esm5)."
|
||
|
||
|
||
# Did it handle namespace imported decorators in UMD using `__decorate` syntax?
|
||
grep "type: i0.Injectable" node_modules/@angular/common/bundles/common.umd.js
|
||
assertSucceeded "Expected 'ngcc' to correctly handle '__decorate' syntax in '@angular/common' (umd)."
|
||
|
||
# (and ensure the @angular/common package is indeed using `__decorate` syntax)
|
||
grep "JsonPipe = __decorate(" node_modules/@angular/common/bundles/common.umd.js.__ivy_ngcc_bak
|
||
assertSucceeded "Expected '@angular/common' (umd) to actually use '__decorate' syntax."
|
||
|
||
|
||
# Did it handle namespace imported decorators in UMD using static properties?
|
||
grep "type: i0.Injectable," node_modules/@angular/cdk/bundles/cdk-a11y.umd.js
|
||
assertSucceeded "Expected 'ngcc' to correctly handle decorators via static properties in '@angular/cdk/a11y' (umd)."
|
||
|
||
# (and ensure the @angular/cdk/a11y package is indeed using static properties)
|
||
grep "FocusMonitor.decorators =" node_modules/@angular/cdk/bundles/cdk-a11y.umd.js.__ivy_ngcc_bak
|
||
assertSucceeded "Expected '@angular/cdk/a11y' (umd) to actually have decorators via static properties."
|
||
|
||
|
||
# Did it transform imports in UMD correctly?
|
||
# (E.g. no trailing commas, so that it remains compatible with legacy browsers, such as IE11.)
|
||
grep "factory(exports, require('rxjs'), require('rxjs/operators'))" node_modules/@angular/core/bundles/core.umd.js
|
||
assertSucceeded "Expected 'ngcc' to not add trailing commas to CommonJS block in UMD."
|
||
|
||
grep "define('@angular/core', \['exports', 'rxjs', 'rxjs/operators'], factory)" node_modules/@angular/core/bundles/core.umd.js
|
||
assertSucceeded "Expected 'ngcc' to not add trailing commas to AMD block in UMD."
|
||
|
||
grep "factory((global.ng = global.ng || {}, global.ng.core = {}), global.rxjs, global.rxjs.operators)" node_modules/@angular/core/bundles/core.umd.js
|
||
assertSucceeded "Expected 'ngcc' to not add trailing commas to globals block in UMD."
|
||
|
||
grep "(this, (function (exports, rxjs, operators) {" node_modules/@angular/core/bundles/core.umd.js
|
||
assertSucceeded "Expected 'ngcc' to not add trailing commas to factory function parameters in UMD."
|
||
|
||
|
||
# Can it be safely run again (as a noop)?
|
||
# And check that it logged skipping compilation as expected
|
||
ngcc -l debug | grep 'Skipping'
|
||
assertSucceeded "Expected 'ngcc -l debug' to successfully rerun (as a noop) and log 'Skipping'."
|
||
|
||
# Does it process the tasks in parallel?
|
||
ngcc -l debug | grep 'Running ngcc on ClusterExecutor'
|
||
assertSucceeded "Expected 'ngcc -l debug' to run in parallel mode (using 'ClusterExecutor')."
|
||
|
||
# Check that running it with logging level error outputs nothing
|
||
ngcc -l error | grep '.'
|
||
assertFailed "Expected 'ngcc -l error' to not output anything."
|
||
|
||
# Does running it with --formats fail?
|
||
ngcc --formats fesm2015
|
||
assertFailed "Expected 'ngcc --formats fesm2015' to fail (since '--formats' is deprecated)."
|
||
|
||
# Now try compiling the app using the ngcc compiled libraries
|
||
ngc -p tsconfig-app.json
|
||
assertSucceeded "Expected the app to successfully compile with the ngcc-processed libraries."
|
||
|
||
# Did it compile the main.ts correctly (including the ngIf and MatButton directives)?
|
||
grep "directives: \[.*\.NgIf.*\]" dist/src/main.js
|
||
assertSucceeded "Expected the compiled app's 'main.ts' to list 'NgIf' in 'directives'."
|
||
|
||
grep "directives: \[.*\.MatButton.*\]" dist/src/main.js
|
||
assertSucceeded "Expected the compiled app's 'main.ts' to list 'MatButton' in 'directives'."
|
||
|
||
|
||
# 'ivy-ngcc' should fail with an appropriate error message.
|
||
ivy-ngcc
|
||
assertFailed "Expected 'ivy-ngcc' to fail (since it was renamed to 'ngcc')."
|
||
|
||
ivy-ngcc 2>&1 | grep "Error: The 'ivy-ngcc' command was renamed to just 'ngcc'. Please update your usage."
|
||
assertSucceeded "Expected 'ivy-ngcc' to show an appropriate error message."
|