9b93bd625f
Previous to this change, we assumed embedded views could only be created after their parent template node had completed processing. As a result, we only set up query logic for containers after directives on the node were created. However, this assumption didn't take into account the case where a directive on a template node could create views in its constructor. This commit fixes query logic to work with views created in constructors. In that case, we need to create a query container before the new view is rendered so query results in the view aren't lost. But since the query container is created before directives have completed processing, we also have to ensure that query results gathered later on the template node are inserted before that query container. Otherwise, query results in embedded views will clobber query results on template nodes. This splice mode may be slightly slower than the normal matching for queries on containers, but we should only fall back to this strategy in the edge case where views are created in constructors. (We should encourage developers to create views in ngOnInit instead). PR Close #29983 |
||
|---|---|---|
| .buildkite | ||
| .circleci | ||
| .codefresh | ||
| .github | ||
| .vscode | ||
| aio | ||
| docs | ||
| integration | ||
| modules | ||
| packages | ||
| scripts | ||
| third_party | ||
| tools | ||
| .bazelignore | ||
| .bazelrc | ||
| .clang-format | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .nvmrc | ||
| BUILD.bazel | ||
| CHANGELOG.md | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| README.md | ||
| WORKSPACE | ||
| browser-providers.conf.js | ||
| gulpfile.js | ||
| karma-js.conf.js | ||
| package.json | ||
| protractor-perf.conf.js | ||
| renovate.json | ||
| shims_for_IE.js | ||
| test-events.js | ||
| test-main.js | ||
| tslint.json | ||
| yarn.lock | ||
| yarn.lock.readme.md | ||
README.md
Angular
Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.
Quickstart
Changelog
Learn about the latest improvements.
Want to help?
Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.