angular-cn/packages/core/schematics/migrations/missing-injectable
Paul Gschwendtner 28995dba19 fix(core): missing-injectable migration should not migrate `@NgModule` classes (#36369)
Based on the migration guide, provided classes which don't have
either `@Injectable`, `@Directive`, `@Component` or `@Pipe` need
to be migrated.

This is not correct as provided classes with an `@NgModule` also
have a factory function that can be read by the r3 injector. It's
unclear in which cases the `@NgModule` decorator is used for
provided classes, but this scenario has been reported.

Either we fix this in the migration, or we make sure to report
this as unsupported in the Ivy compiler.

Fixes #35700.

PR Close #36369
2020-04-21 12:54:24 -04:00
..
google3 build: reformat repo to new clang@1.4.0 (#36613) 2020-04-14 12:08:36 -07:00
BUILD.bazel fix(core): missing-injectable migration should handle forwardRef (#33286) 2019-10-25 13:26:00 -07:00
definition_collector.ts build: reformat repo to new clang@1.4.0 (#36613) 2020-04-14 12:08:36 -07:00
index.ts fix(core): avoid migration error when non-existent symbol is imported (#36367) 2020-04-06 13:21:54 -07:00
providers_evaluator.ts feat(core): missing-injectable migration should migrate empty object literal providers (#33709) 2019-11-18 15:47:20 -08:00
transform.ts fix(core): missing-injectable migration should not migrate `@NgModule` classes (#36369) 2020-04-21 12:54:24 -04:00
update_recorder.ts refactor(core): move schematic import manager to shared utils (#35339) 2020-04-02 10:51:48 -07:00