7849fdde09
In #38227 the signatures of `navigateByUrl` and `createUrlTree` were updated to exclude unsupported properties from their `extras` parameter. This migration looks for the relevant method calls that pass in an `extras` parameter and drops the unsupported properties. **Before:** ``` this._router.navigateByUrl('/', {skipLocationChange: false, fragment: 'foo'}); ``` **After:** ``` this._router.navigateByUrl('/', { /* Removed unsupported properties by Angular migration: fragment. */ skipLocationChange: false }); ``` These changes also move the method call detection logic out of the `Renderer2` migration and into a common place so that it can be reused in other migrations. PR Close #38825
39 lines
1.4 KiB
TypeScript
39 lines
1.4 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {Replacement, RuleFailure, Rules} from 'tslint';
|
|
import * as ts from 'typescript';
|
|
import {findLiteralsToMigrate, migrateLiteral} from '../../migrations/navigation-extras-omissions/util';
|
|
|
|
|
|
/** TSLint rule that migrates `navigateByUrl` and `createUrlTree` calls to an updated signature. */
|
|
export class Rule extends Rules.TypedRule {
|
|
applyWithProgram(sourceFile: ts.SourceFile, program: ts.Program): RuleFailure[] {
|
|
const failures: RuleFailure[] = [];
|
|
const typeChecker = program.getTypeChecker();
|
|
const printer = ts.createPrinter();
|
|
const literalsToMigrate = findLiteralsToMigrate(sourceFile, typeChecker);
|
|
|
|
literalsToMigrate.forEach((instances, methodName) => instances.forEach(instance => {
|
|
const migratedNode = migrateLiteral(methodName, instance);
|
|
|
|
if (migratedNode !== instance) {
|
|
failures.push(new RuleFailure(
|
|
sourceFile, instance.getStart(), instance.getEnd(),
|
|
'Object used in navigateByUrl or createUrlTree call contains unsupported properties.',
|
|
this.ruleName,
|
|
new Replacement(
|
|
instance.getStart(), instance.getWidth(),
|
|
printer.printNode(ts.EmitHint.Unspecified, migratedNode, sourceFile))));
|
|
}
|
|
}));
|
|
|
|
return failures;
|
|
}
|
|
}
|