angular-cn/packages/core/schematics/migrations/static-queries
Alan Agius 80394ce08b fix(core): TypeScript related migrations should cater for BOM (#30719)
fix(@schematics/angular): TypeScript related migrations should cater for BOM

In the CLI `UpdateRecorder` methods such as `insertLeft`, `remove` etc.. accepts positions which are not offset by a BOM. This is because when a file has a BOM a different recorder will be used https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/schematics/src/tree/recorder.ts#L72 which caters for an addition offset/delta.

The main reason for this is that when a developer is writing a schematic they shouldn't need to compute the offset based if a file has a BOM or not and is handled out of the box.

Example
```ts
recorder.insertLeft(5, 'true');
```

However this is unfortunate in the case if a ts SourceFile is used and one uses `getWidth` and `getStart` method they will already be offset by 1, which at the end it results in a double offset and hence the problem.

Fixes #30713

PR Close #30719
2019-05-30 20:48:45 -07:00
..
angular fix(core): static-query migration should handle queries on accessors (#30327) 2019-05-09 11:22:37 -07:00
google3 build: update rules_nodejs and clean up bazel warnings (#30370) 2019-05-14 10:08:45 -07:00
strategies refactor(core): static-query migration should warn about syntax failures (#30628) 2019-05-23 10:31:48 -07:00
BUILD.bazel build: update rules_nodejs and clean up bazel warnings (#30370) 2019-05-14 10:08:45 -07:00
index.ts fix(core): TypeScript related migrations should cater for BOM (#30719) 2019-05-30 20:48:45 -07:00
transform.ts refactor(core): improve messages for static-query migrations (#30458) 2019-05-14 14:04:44 -07:00