69510acb20
The js_expected_symbol_test implementation extracts symbols names from a rollup iife bundle. Previously, it only handled the case with a simple 'var bundle = ...;' statement. Sometimes, rollup produces a more complex bundle, where the 'bundle' variable is not the only top-level variable declared in the same declaration statement. This commit patches the symbol exctractor to support this more complex case. Additionally, when the symbol test fails, it prints a command to accept the symbol diff. This command needs to include the --define=compile flag to ensure the diff is applied in the same compile mode as the test was run. PR Close #24677
52 lines
1.6 KiB
TypeScript
52 lines
1.6 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import {SymbolExtractor} from './symbol_extractor';
|
|
|
|
if (require.main === module) {
|
|
const args = process.argv.slice(2) as[string, string];
|
|
process.exitCode = main(args) ? 0 : 1;
|
|
}
|
|
|
|
/**
|
|
* CLI main method.
|
|
*
|
|
* ```
|
|
* cli javascriptFilePath.js goldenFilePath.json
|
|
* ```
|
|
*/
|
|
function main(argv: [string, string, string] | [string, string]): boolean {
|
|
const javascriptFilePath = require.resolve(argv[0]);
|
|
const goldenFilePath = require.resolve(argv[1]);
|
|
const doUpdate = argv[2] == '--accept';
|
|
|
|
const javascriptContent = fs.readFileSync(javascriptFilePath).toString();
|
|
const goldenContent = fs.readFileSync(goldenFilePath).toString();
|
|
|
|
const symbolExtractor = new SymbolExtractor(javascriptFilePath, javascriptContent);
|
|
|
|
let passed: boolean = false;
|
|
if (doUpdate) {
|
|
fs.writeFileSync(goldenFilePath, JSON.stringify(symbolExtractor.actual, undefined, 2));
|
|
console.error('Updated gold file:', goldenFilePath);
|
|
passed = true;
|
|
} else {
|
|
passed = symbolExtractor.compareAndPrintError(goldenFilePath, goldenContent);
|
|
if (!passed) {
|
|
const compile = process.env['compile'];
|
|
const defineFlag = (compile !== 'legacy') ? `--define=compile=${compile} ` : '';
|
|
console.error(`TEST FAILED!`);
|
|
console.error(` To update the golden file run: `);
|
|
console.error(` bazel run ${defineFlag}${process.env['BAZEL_TARGET']}.accept`);
|
|
}
|
|
}
|
|
return passed;
|
|
}
|