71079ce47e
This commit fixes a regression from "fix(common): ensure scrollRestoration is writable (#30630)" that caused scrolling to not happen at all in browsers that do not support scroll restoration. The issue was that `supportScrollRestoration` was updated to return `false` if a browser did not have a writable `scrollRestoration`. However, the previous behavior was that the function would return `true` if `window.scrollTo` was defined. Every scrolling function in the `ViewportScroller` used `supportScrollRestoration` and, with the update in bb88c9fa3daac80086efbda951d81c159e3840f4, no scrolling would be performed if a browser did not have writable `scrollRestoration` but _did_ have `window.scrollTo`. Note, that this failure was detected in the saucelabs tests. IE does not support scroll restoration so IE tests were failing. PR Close #38468
76 lines
3.0 KiB
TypeScript
76 lines
3.0 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {describe, expect, it} from '@angular/core/testing/src/testing_internal';
|
|
import {BrowserViewportScroller, ViewportScroller} from '../src/viewport_scroller';
|
|
|
|
describe('BrowserViewportScroller', () => {
|
|
let scroller: ViewportScroller;
|
|
let documentSpy: any;
|
|
let windowSpy: any;
|
|
|
|
beforeEach(() => {
|
|
windowSpy = jasmine.createSpyObj('window', ['history', 'scrollTo']);
|
|
windowSpy.history.scrollRestoration = 'auto';
|
|
documentSpy = jasmine.createSpyObj('document', ['getElementById', 'getElementsByName']);
|
|
scroller = new BrowserViewportScroller(documentSpy, windowSpy, null!);
|
|
});
|
|
|
|
describe('setHistoryScrollRestoration', () => {
|
|
function createNonWritableScrollRestoration() {
|
|
Object.defineProperty(windowSpy.history, 'scrollRestoration', {
|
|
value: 'auto',
|
|
configurable: true,
|
|
});
|
|
}
|
|
|
|
it('should not crash when scrollRestoration is not writable', () => {
|
|
createNonWritableScrollRestoration();
|
|
expect(() => scroller.setHistoryScrollRestoration('manual')).not.toThrow();
|
|
});
|
|
|
|
it('should still allow scrolling if scrollRestoration is not writable', () => {
|
|
createNonWritableScrollRestoration();
|
|
scroller.scrollToPosition([10, 10]);
|
|
expect(windowSpy.scrollTo as jasmine.Spy).toHaveBeenCalledWith(10, 10);
|
|
});
|
|
});
|
|
|
|
describe('scrollToAnchor', () => {
|
|
const anchor = 'anchor';
|
|
const el = document.createElement('a');
|
|
|
|
it('should only call getElementById when an element is found by id', () => {
|
|
documentSpy.getElementById.and.returnValue(el);
|
|
spyOn<any>(scroller, 'scrollToElement');
|
|
scroller.scrollToAnchor(anchor);
|
|
expect(documentSpy.getElementById).toHaveBeenCalledWith(anchor);
|
|
expect(documentSpy.getElementsByName).not.toHaveBeenCalled();
|
|
expect((scroller as any).scrollToElement).toHaveBeenCalledWith(el);
|
|
});
|
|
|
|
it('should call getElementById and getElementsByName when an element is found by name', () => {
|
|
documentSpy.getElementsByName.and.returnValue([el]);
|
|
spyOn<any>(scroller, 'scrollToElement');
|
|
scroller.scrollToAnchor(anchor);
|
|
expect(documentSpy.getElementById).toHaveBeenCalledWith(anchor);
|
|
expect(documentSpy.getElementsByName).toHaveBeenCalledWith(anchor);
|
|
expect((scroller as any).scrollToElement).toHaveBeenCalledWith(el);
|
|
});
|
|
|
|
it('should not call scrollToElement when an element is not found by its id or its name', () => {
|
|
documentSpy.getElementsByName.and.returnValue([]);
|
|
spyOn<any>(scroller, 'scrollToElement');
|
|
scroller.scrollToAnchor(anchor);
|
|
expect(documentSpy.getElementById).toHaveBeenCalledWith(anchor);
|
|
expect(documentSpy.getElementsByName).toHaveBeenCalledWith(anchor);
|
|
expect((scroller as any).scrollToElement).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|