ab8199f7c9
This is a follow-up to #35049 with a few minor fixes related to using the browser provided by `puppeteer` to run tests. Included fixes: - Make the `webdriver-manager-update.js` really portable. (Previously, it needed to be run from the directory that contained the `node_modules/` directory. Now, it can be executed from a subdirectory and will correctly resolve dependencies.) - Use the `puppeteer`-based setup in AIO unit and e2e tests to ensure that the downloaded ChromeDriver version matches the browser version used in tests. - Use the `puppeteer`-based setup in the `aio_monitoring_stable` CI job (as happens with `aio_monitoring_next`). - Use the [recommended way][1] of getting the browser port when using `puppeteer` with `lighthouse` and avoid hard-coding the remote debugging port (to be able to handle multiple instances running concurrently). [1]: https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49 PR Close #35381
44 lines
1.6 KiB
JavaScript
Executable File
44 lines
1.6 KiB
JavaScript
Executable File
#!/usr/bin/env node
|
|
'use strict';
|
|
|
|
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
// Use process.cwd() so that this script is portable and can be used in /aio
|
|
// where this will require /aio/node_modules/puppeteer
|
|
const puppeteerPkgPath = require.resolve('puppeteer/package.json', {paths: [process.cwd()]});
|
|
const puppeteerVersion = require(puppeteerPkgPath).version;
|
|
const chromeVersionMap = require('./puppeteer-chrome-versions');
|
|
const spawnSync = require('child_process').spawnSync;
|
|
|
|
const version = chromeVersionMap[puppeteerVersion];
|
|
if (!version) {
|
|
console.error(`[webdriver-manager-update.js] Error: Could not find Chrome version for Puppeteer version '${puppeteerVersion}' in Chrome/Puppeteer version map. Please update /scripts/puppeteer-chrome-versions.js.`);
|
|
process.exit(1);
|
|
}
|
|
|
|
const args = [
|
|
'webdriver-manager',
|
|
'update',
|
|
'--gecko=false',
|
|
'--standalone=false',
|
|
'--versions.chrome',
|
|
version,
|
|
// Append additional user arguments after script default arguments
|
|
...process.argv.slice(2),
|
|
];
|
|
|
|
const result = spawnSync('yarn', args, {shell: true, stdio: 'inherit'});
|
|
if (result.error) {
|
|
console.error(`[webdriver-manager-update.js] Call to 'yarn ${args.join(' ')}' failed with error code ${result.error.code}`);
|
|
process.exit(result.status);
|
|
}
|
|
if (result.status) {
|
|
console.error(`[webdriver-manager-update.js] Call to 'yarn ${args.join(' ')}' failed with error code ${result.status}`);
|
|
process.exit(result.status);
|
|
}
|