8c2cbdd385
During TypeScript module resolution, a lot of filesystem requests are done. This is quite an expensive operation, so a module resolution cache can be used to speed up the process significantly. This commit lets the Ivy compiler perform all module resolution with a module resolution cache. Note that the module resolution behavior can be changed with a custom compiler host, in which case that custom host implementation is responsible for caching. In the case of the Angular CLI a custom compiler host with proper module resolution caching is already in place, so the CLI already has this optimization. PR Close #34332
92 lines
4.2 KiB
TypeScript
92 lines
4.2 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
import {CycleAnalyzer, ImportGraph} from '../../cycles';
|
|
import {ErrorCode, FatalDiagnosticError} from '../../diagnostics';
|
|
import {absoluteFrom} from '../../file_system';
|
|
import {runInEachFileSystem} from '../../file_system/testing';
|
|
import {ModuleResolver, NOOP_DEFAULT_IMPORT_RECORDER, ReferenceEmitter} from '../../imports';
|
|
import {CompoundMetadataReader, DtsMetadataReader, LocalMetadataRegistry} from '../../metadata';
|
|
import {PartialEvaluator} from '../../partial_evaluator';
|
|
import {TypeScriptReflectionHost, isNamedClassDeclaration} from '../../reflection';
|
|
import {LocalModuleScopeRegistry, MetadataDtsModuleScopeResolver} from '../../scope';
|
|
import {getDeclaration, makeProgram} from '../../testing';
|
|
import {ResourceLoader} from '../src/api';
|
|
import {ComponentDecoratorHandler} from '../src/component';
|
|
|
|
export class NoopResourceLoader implements ResourceLoader {
|
|
resolve(): string { throw new Error('Not implemented.'); }
|
|
canPreload = false;
|
|
load(): string { throw new Error('Not implemented'); }
|
|
preload(): Promise<void>|undefined { throw new Error('Not implemented'); }
|
|
}
|
|
runInEachFileSystem(() => {
|
|
describe('ComponentDecoratorHandler', () => {
|
|
let _: typeof absoluteFrom;
|
|
beforeEach(() => _ = absoluteFrom);
|
|
|
|
it('should produce a diagnostic when @Component has non-literal argument', () => {
|
|
const {program, options, host} = makeProgram([
|
|
{
|
|
name: _('/node_modules/@angular/core/index.d.ts'),
|
|
contents: 'export const Component: any;',
|
|
},
|
|
{
|
|
name: _('/entry.ts'),
|
|
contents: `
|
|
import {Component} from '@angular/core';
|
|
|
|
const TEST = '';
|
|
@Component(TEST) class TestCmp {}
|
|
`
|
|
},
|
|
]);
|
|
const checker = program.getTypeChecker();
|
|
const reflectionHost = new TypeScriptReflectionHost(checker);
|
|
const evaluator = new PartialEvaluator(reflectionHost, checker, /* dependencyTracker */ null);
|
|
const moduleResolver =
|
|
new ModuleResolver(program, options, host, /* moduleResolutionCache */ null);
|
|
const importGraph = new ImportGraph(moduleResolver);
|
|
const cycleAnalyzer = new CycleAnalyzer(importGraph);
|
|
const metaRegistry = new LocalMetadataRegistry();
|
|
const dtsReader = new DtsMetadataReader(checker, reflectionHost);
|
|
const scopeRegistry = new LocalModuleScopeRegistry(
|
|
metaRegistry, new MetadataDtsModuleScopeResolver(dtsReader, null),
|
|
new ReferenceEmitter([]), null);
|
|
const metaReader = new CompoundMetadataReader([metaRegistry, dtsReader]);
|
|
const refEmitter = new ReferenceEmitter([]);
|
|
|
|
const handler = new ComponentDecoratorHandler(
|
|
reflectionHost, evaluator, metaRegistry, metaReader, scopeRegistry, scopeRegistry,
|
|
/* isCore */ false, new NoopResourceLoader(), /* rootDirs */[''],
|
|
/* defaultPreserveWhitespaces */ false, /* i18nUseExternalIds */ true,
|
|
/* enableI18nLegacyMessageIdFormat */ false, moduleResolver, cycleAnalyzer, refEmitter,
|
|
NOOP_DEFAULT_IMPORT_RECORDER, /* depTracker */ null,
|
|
/* annotateForClosureCompiler */ false);
|
|
const TestCmp = getDeclaration(program, _('/entry.ts'), 'TestCmp', isNamedClassDeclaration);
|
|
const detected = handler.detect(TestCmp, reflectionHost.getDecoratorsOfDeclaration(TestCmp));
|
|
if (detected === undefined) {
|
|
return fail('Failed to recognize @Component');
|
|
}
|
|
try {
|
|
handler.analyze(TestCmp, detected.metadata);
|
|
return fail('Analysis should have failed');
|
|
} catch (err) {
|
|
if (!(err instanceof FatalDiagnosticError)) {
|
|
return fail('Error should be a FatalDiagnosticError');
|
|
}
|
|
const diag = err.toDiagnostic();
|
|
expect(diag.code).toEqual(ivyCode(ErrorCode.DECORATOR_ARG_NOT_LITERAL));
|
|
expect(diag.file.fileName.endsWith('entry.ts')).toBe(true);
|
|
expect(diag.start).toBe(detected.metadata.args ![0].getStart());
|
|
}
|
|
});
|
|
});
|
|
|
|
function ivyCode(code: ErrorCode): number { return Number('-99' + code.valueOf()); }
|
|
});
|