angular-cn/packages/core/testing
Alex Rickabaugh 7b27009e20 fix(ivy): fix proliferation of provider overrides for modules (#29571)
When an @NgModule is imported more than once in the testing module (for
example it appears in the imports of more than one module, or if it's
literally listed multiple times), then TestBed had a bug where the
providers for the module would be overridden many times.

This alone was problematic but would not break tests. However, the original
value of the providers field of the ngInjectorDef was saved each time, and
restored in the same order. Thus, if the provider array was [X], and
overrides were applied twice, then the override array would become
[X, X'] and then [X, X', X, X']. However, on the second override the state
[X, X'] would be stored as original. The array would then be restored to
[X] and then [X, X'].

Each test, therefore, would continue to double the size of the providers
array for the module, eventually exhausting the browser's memory.

This commit adds a Set to track when overrides have been applied to a module
and refrain from applying them more than once.

PR Close #29571
2019-03-28 13:59:25 -07:00
..
src fix(ivy): fix proliferation of provider overrides for modules (#29571) 2019-03-28 13:59:25 -07:00
BUILD.bazel build: enable bundle_dts for core package (#28884) 2019-03-08 12:36:55 -08:00
index.ts build: publish tree of files rather than FESMs (#18541) 2017-08-31 15:34:50 -07:00
package.json fix: correct several esm2015 entry-points in package.jsons (#22892) 2018-03-20 13:30:08 -07:00
public_api.ts build: refactor ambient node & jasmine types so they are only included where needed (#25491) 2018-08-16 13:46:43 -07:00
tsconfig-build.json feat(ivy): implement TestBed (#25369) 2018-08-14 11:58:47 -07:00