angular-cn/dev-infra
Andrew Scott 67e3ecc7e3 fix(dev-infra): Ensure conditions with groups do not fail verification (#37798)
There are a few changes in this PR to ensure conditions that are based
on groups (i.e. `- groups.pending.length == 0`) do not fail the verify
task:

* Remove the warning when a condition is encountered that depends on the
`groups` state. The warning will otherwise be printed once for every
file that triggers the execution of the condition (400,000+ times)
* Add an `unverifiable` flag to `GroupCondition` interface and set it to
true when an error is encountered due to attempting to get the state of
`groups` in a condition
* Ignore any unverifiable conditions when gathering unmatched
conditions. These should not be considered `unmatched` for verification
purposes.
* Print the unverifiable conditions by group in the results

Sample output:
```

┌──────────────────────────────────────────────────────────────────────────────┐
│                         PullApprove results by group                         │
└──────────────────────────────────────────────────────────────────────────────┘
Groups skipped (4 groups)
Matched conditions by Group (37 groups)
Unmatched conditions by Group (0 groups)
Unverifiable conditions by Group (3 groups)
  [public-api]
    len(groups.pending.exclude("required-minimum-review")...
    len(groups.rejected.exclude("required-minimum-review")...
  [size-tracking]
    len(groups.pending.exclude("required-minimum-review")...
    len(groups.rejected.exclude("required-minimum-review")...
  [circular-dependencies]
    len(groups.pending.exclude("required-minimum-review")...
    len(groups.rejected.exclude("required-minimum-review")...

```

PR Close #37798
2020-07-24 17:59:39 -07:00
..
bazel fix(dev-infra): add missing BUILD file to dev-infra/bazel:files (#38026) 2020-07-15 12:34:46 -07:00
benchmark feat(dev-infra): add bazel firefox browser with RBE compatibility (#38029) 2020-07-15 12:34:05 -07:00
browsers feat(dev-infra): add bazel firefox browser with RBE compatibility (#38029) 2020-07-15 12:34:05 -07:00
commit-message feat(dev-infra): commit message validation should skip lines consisting of URLs (#37890) 2020-07-10 10:59:28 -07:00
format build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00
pr feat(dev-infra): merge script should link to original commit when cherry-picking with API strategy (#37889) 2020-07-07 12:16:21 -07:00
pullapprove fix(dev-infra): Ensure conditions with groups do not fail verification (#37798) 2020-07-24 17:59:39 -07:00
release refactor(dev-infra): use the `exec()` helper from `utils/shelljs` whenever possible (#37444) 2020-06-05 09:21:18 -07:00
ts-circular-dependencies style(dev-infra): correct tslint failures in dev-infra directory (#37233) 2020-06-04 12:44:46 -07:00
utils refactor(dev-infra): Add support for groups in the conditions evaluator (#38164) 2020-07-23 11:05:42 -07:00
BUILD.bazel fix(dev-infra): fix broken zone.js substitution for dev-infra:npm_package (#38026) 2020-07-15 12:34:46 -07:00
cli.ts build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00
index.bzl refactor(dev-infra): allow for consumption with rules_nodejs v2.0.0 (#37968) 2020-07-13 14:18:22 -07:00
ng-dev build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00
tmpl-package.json refactor(dev-infra): migrate github api in GitClient to rely on GithubClient (#37593) 2020-06-22 10:54:43 -07:00