angular-cn/packages/compiler-cli/linker
Pete Bacon Darwin 05672ab136 refactor(compiler-cli): `attachComments()` now expects a defined `leadingComments` array (#39076)
Previously the value passed to `AstFactory.attachComments()` could be
`undefined` which is counterintuitive, since why attach something that
doesn't exist? Now it expects there to be a defined array. Further it no
longer returns a statement. Both these aspects of the interface were designed
to make the usage simpler but has the result of complicating the implemenation.

The `ExpressionTranslatorVisitor` now has a helper function (`attachComments()`)
to handle `leadingComments` being undefined and also returning the statement.
This keeps the usage in the translator simple, while ensuring that the `AstFactory`
API is not influenced by how it is used.

PR Close #39076
2020-10-06 11:33:55 -07:00
..
src refactor(compiler-cli): `attachComments()` now expects a defined `leadingComments` array (#39076) 2020-10-06 11:33:55 -07:00
test refactor(compiler-cli): implement `BabelAstFactory` and `AstHost`s (#38866) 2020-10-01 09:32:12 -07:00
BUILD.bazel refactor(compiler-cli): implement `BabelAstFactory` and `AstHost`s (#38866) 2020-10-01 09:32:12 -07:00
index.ts refactor(compiler-cli): implement `BabelAstFactory` and `AstHost`s (#38866) 2020-10-01 09:32:12 -07:00