bb290cefae
Originally, QueryList implemented Iterable and provided a Symbol.iterator on its prototype. This caused issues with tree-shaking, so QueryList was refactored and the Symbol.iterator added in its constructor instead. As part of this change, QueryList no longer implemented Iterable directly. Unfortunately, this meant that QueryList was no longer assignable to Iterable or, consequently, NgIterable. NgIterable is used for NgFor's input, so this meant that QueryList was not usable (in a type sense) for NgFor iteration. View Engine's template type checking would not catch this, but Ivy's did. As a fix, this commit adds the declaration (but not the implementation) of the Symbol.iterator function back to QueryList. This has no runtime effect, so it doesn't affect tree-shaking of QueryList, but it ensures that QueryList is assignable to NgIterable and thus usable with NgFor. Fixes #29842 PR Close #33536
77 lines
2.5 KiB
Python
77 lines
2.5 KiB
Python
# Copyright 2017 The Bazel Authors. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""Runs ts_api_guardian
|
|
"""
|
|
|
|
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary", "nodejs_test")
|
|
|
|
COMMON_MODULE_IDENTIFIERS = ["angular", "jasmine", "protractor", "Symbol"]
|
|
|
|
def ts_api_guardian_test(
|
|
name,
|
|
golden,
|
|
actual,
|
|
data = [],
|
|
strip_export_pattern = ["^__", "^ɵ[^ɵ]"],
|
|
allow_module_identifiers = COMMON_MODULE_IDENTIFIERS,
|
|
use_angular_tag_rules = True,
|
|
**kwargs):
|
|
"""Runs ts_api_guardian
|
|
"""
|
|
data += [
|
|
# Locally we need to add the TS build target
|
|
# But it will replaced to @npm//ts-api-guardian when publishing
|
|
"@angular//tools/ts-api-guardian:lib",
|
|
"@angular//tools/ts-api-guardian:bin",
|
|
# The below are required during runtime
|
|
"@npm//chalk",
|
|
"@npm//diff",
|
|
"@npm//minimist",
|
|
"@npm//typescript",
|
|
]
|
|
|
|
args = [
|
|
# Needed so that node doesn't walk back to the source directory.
|
|
# From there, the relative imports would point to .ts files.
|
|
"--node_options=--preserve-symlinks",
|
|
]
|
|
|
|
for i in strip_export_pattern:
|
|
# The below replacement is needed because under Windows '^' needs to be escaped twice
|
|
args += ["--stripExportPattern", i.replace("^", "^^^^")]
|
|
|
|
for i in allow_module_identifiers:
|
|
args += ["--allowModuleIdentifiers", i]
|
|
|
|
if use_angular_tag_rules:
|
|
args += ["--useAngularTagRules"]
|
|
|
|
nodejs_test(
|
|
name = name,
|
|
data = data,
|
|
entry_point = "@angular//tools/ts-api-guardian:bin/ts-api-guardian",
|
|
templated_args = args + ["--verify", golden, actual],
|
|
**kwargs
|
|
)
|
|
|
|
nodejs_binary(
|
|
name = name + ".accept",
|
|
testonly = True,
|
|
data = data,
|
|
entry_point = "@angular//tools/ts-api-guardian:bin/ts-api-guardian",
|
|
templated_args = args + ["--out", golden, actual],
|
|
**kwargs
|
|
)
|