c34c223122
ivy's bindingUpdated instruction is using the assertNotEqual check to make sure that NO_CHANGE value (of type Object) is not passed as a value to be dirty-checked. In practice it means that any value passed as a binding value would be compared to the NO_CHANGE object. It turns out that the assertNotEqual is using == and given that binding values are of different type and we always compare it to the NO_CHANGE object we were doing lots of type coercion. It resulted in calls to expensive types conversions and calls to Object.toString(). A profiler reported ~15% of the self time spent in the assertNotEqual but it turns out that removing type coercion speeds up Material Chips with input scenario much more (~40ms down to ~20ms). This PR introduces new assert method `assertNotSame` that uses strict equality check. The new assertion is used in binding instructions to compare to NO_CHANGE object reference. PR Close #29470 |
||
|---|---|---|
| .. | ||
| schematics | ||
| src | ||
| test | ||
| testing | ||
| BUILD.bazel | ||
| PACKAGE.md | ||
| index.ts | ||
| package.json | ||
| public_api.ts | ||
| tsconfig-build.json | ||