honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
angular-cn/packages
History
Pete Bacon Darwin c986d3dcf4 fix(upgrade): upgrade Directive facade should not return different instance from constructor (#27660) 
In ngUpgrade (dynamic) we create a dynamic Angular `Directive` that wraps AngularJS components
that are being upgraded. The constructor of this `Directive` class returns a different instance
than `this`. It is this instance that actually contains the life-cycle hook handlers.

This would break in ivy, since the methods on the prototype of the original class are wired up,
rather than the instance methods. This results in hooks like `ngOnInit` not being called.

This commit refactors the code to extend the inner class that was being returned so that the
prototype chain is correct for both ViewEngine and ivy.

This change resolves a number of failing ivy tests, but also exposes other failures that were
masked by this issue. The tests have been updated accordingly.

(FW-812)

PR Close #27660
 		2018-12-17 14:51:34 -08:00
..
animations docs(animations): rename animateChild() to animate() (#26184) 2018-12-14 15:27:37 -08:00
bazel fix(bazel): emit full node stack traces when Angular compilation crashes (#27678) 2018-12-14 14:58:21 -08:00
benchpress build: fix type-check errors introduced during rules_ts 0.21 (#27586) 2018-12-10 16:33:41 -08:00
common test(ivy): enable all test for @angular/common (#27700) 2018-12-17 09:32:09 -08:00
compiler fix(ivy): provide an ability to match <ng-template> tags (#27636) 2018-12-17 09:33:37 -08:00
compiler-cli perf(ivy): let ngcc first check marker file before assembling bundle (#27438) 2018-12-17 09:35:16 -08:00
core fix(ivy): check semantics of NgModule for consistency (#27604) 2018-12-17 14:49:51 -08:00
docs refactor: move angular source to /packages rather than modules/@angular 2017-03-08 16:29:27 -08:00
elements build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
examples docs: remove obsolete packages/examples/web_workers/ts/.gitkeep (#27386) 2018-12-05 20:55:32 -08:00
forms build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
http build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
language-service build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
platform-browser build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
platform-browser-dynamic build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
platform-server fix(ivy): check semantics of NgModule for consistency (#27604) 2018-12-17 14:49:51 -08:00
platform-webworker build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
platform-webworker-dynamic build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
private/testing test: correct bazel visibility for @angular/private/testing (#27386) 2018-12-05 20:55:32 -08:00
router fix(ivy): check semantics of NgModule for consistency (#27604) 2018-12-17 14:49:51 -08:00
service-worker build: restrict visibility of npm_package targets (#27611) 2018-12-14 10:20:40 -08:00
upgrade fix(upgrade): upgrade Directive facade should not return different instance from constructor (#27660) 2018-12-17 14:51:34 -08:00
BUILD.bazel build(bazel): use fine-grained npm deps (#26111) (#26488) 2018-10-19 20:59:29 -07:00
README.md Revert "docs: Remove unneeded file (#18106)" 2017-07-20 16:46:47 -05:00
empty.ts refactor: move angular source to /packages rather than modules/@angular 2017-03-08 16:29:27 -08:00
es6-subset.d.ts build: switch from npm to yarn (#19328) 2017-09-22 13:20:52 -07:00
goog.d.ts test(ivy): add bundling test `todo_i18n` (#27420) 2018-12-04 19:59:12 -08:00
license-banner.txt docs(common): update copyright years (#21232) 2018-01-04 17:45:36 -05:00
rollup.config.js refactor: make all rollup config ES5 compatible (#20028) 2017-10-30 23:09:17 -04:00
system.d.ts refactor: move angular source to /packages rather than modules/@angular 2017-03-08 16:29:27 -08:00
tsconfig-build.json build(bazel): Turning on strictPropertyInitialization for Angular. (#24572) 2018-06-25 07:57:13 -07:00
tsconfig-metadata.json fix(compiler): Fix look up of entryComponents in AOT Summaries (#24892) 2018-09-11 16:23:17 -07:00
tsconfig-test.json build: refactor ambient node & jasmine types so they are only included where needed (#25491) 2018-08-16 13:46:43 -07:00
tsconfig.json fix(compiler): Fix look up of entryComponents in AOT Summaries (#24892) 2018-09-11 16:23:17 -07:00
types.d.ts build: refactor ambient node & jasmine types so they are only included where needed (#25491) 2018-08-16 13:46:43 -07:00

README.md

Angular

The sources for this package are in the main Angular repo. Please file issues and pull requests against that repo.

License: MIT